Closed
Bug 1005730
Opened 10 years ago
Closed 10 years ago
Print assertion stacks for MOZ_ASSERT and MOZ_CRASH for code that lives inside libxul
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
4.23 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
The hyphenation changes are necessary because hnjalloc.h #defines FILE to a custom data structure, which clashes with using |stderr| in Assertions.h.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ehsan
Assignee | ||
Updated•10 years ago
|
Attachment #8417126 -
Flags: review?(nfroyd)
Assignee | ||
Comment 2•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=7b26fbf1e30d
Comment 3•10 years ago
|
||
Comment on attachment 8417126 [details] [diff] [review] Print assertion stacks for MOZ_ASSERT and MOZ_CRASH for code that lives inside libxul Review of attachment 8417126 [details] [diff] [review]: ----------------------------------------------------------------- ::: intl/hyphenation/src/hnjstdio.cpp @@ +8,5 @@ > // in hnjalloc.h, so that we can use nsIURI and nsIInputStream to specify and > // access the dictionary resources. > > #include "hnjalloc.h" > +#undef FILE // Undo the damage done in hnjalloc.h O.O
Attachment #8417126 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/62a76f959ae7
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/62a76f959ae7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•