1015829 - libav/ffmpeg runtime binding for 53, 54 and 55

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Add support for libavformat versions 53, 54 and 55 being linked dynamically at runtime.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Runtime binding for libav 53, 54, 55

Comment 2

[Zéfling]

This bug is related to this one? http://www.kdenlive.org/mantis/view.php?id=3292

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

(In reply to Zéfling from comment #2)
> This bug is related to this one?
> http://www.kdenlive.org/mantis/view.php?id=3292

No relation whatsoever. Firefox uses libvpx to decode WebM and also libav support is pref'ed off by default. The current release builds (including 29) use gstreamer for MP4 and MP3 support.

Comment 4

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Runtime binding for libav 53, 54, 55

Comment 5

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8444860 [details] [diff] [review]
Runtime binding for libav 53, 54, 55

Review of attachment 8444860 [details] [diff] [review]:
-----------------------------------------------------------------

A couple nits, but nice overall.

::: content/media/fmp4/ffmpeg/FFmpegDataDecoder.cpp
@@ +21,1 @@
>                                       AVCodecID aCodecID)

nit: whitespace here and elsewhere.

::: content/media/fmp4/ffmpeg/FFmpegRuntimeLinker.cpp
@@ +63,5 @@
>    }
>  
> +  printf_stderr("H264/AAC codecs unsupported without [");
> +  for (size_t i = 0; i < ArrayLength(sLibs); i++) {
> +    printf_stderr("%s %s", i ? "," : "", sLibs[i].Name);

LOG macros, plzkthx, so it can be switched on/off with NSPR_LOG_MODULES.

Comment 6

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://tbpl.mozilla.org/?tree=Try&rev=4bae1be7bd27

Comment 7

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Runtime binding for libav 53, 54, 55

Needed to separate out FFmpegLog.h and FFmpegLog.cpp

Comment 8

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fddd3aa60b52
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce18483bc306

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fddd3aa60b52