10434 - legend.form is always null

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[phillip]

Overview Description:
	legend does not know which form it belongs to (throught the dom)


Steps to Reproduce:
	1) load the attatchment.
	2) read what gets written below the fieldset.

Actual Results:

	This text appears:
		myform.id == myform
		mylegend.form == null


Expected Results:

	This text should appear:
		myform.id == myform
		mylegend.form == myform
		mylegend.form.id == myform

Build Date & Platform:
	1999-07-23-08 build on RedHat 5.2 (Checked Viewer & Apprunner)

Platforms NOT Tested:
	Win32, Mac - because i do not have access to these platforms today.
	since it's a dom bug (or a parser bug), i'm pretty sure it's cross
	platform.

Comment 1

[phillip]

changing QA contact. will add attatchment shortly.

Comment 2

[phillip]

Attachment: testcase that demonstrates bug.

Comment 3

[Micah Dubinko]

Attached testcase verified. Malfunctions on Win98 19990816 build.

Comment 4

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Does this need to get fixed for beta?

Comment 5

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

HTML DOM bugs are M11/P2 for Vidur.

Comment 6

[ekrock's old account (dead)]

Moving to M12.

Comment 7

[vidur (gone)]

Moving off M12 radar for the time being. One or more might get back once I get a
chance to really look at them.

Comment 8

[vidur (gone)]

In an attempt to get my bug list in order again, marking all the bugs I have
currently as ASSIGNED.

Comment 9

[buster]

Attachment: patch that fixes this bug

Comment 10

[buster]

I have attached the diffs for a fix to this bug.
The problem was that the legend content object did not implement nsIFormControl,
and the content sink did not call SetForm on legend content nodes.

I am submitting a secondary bug against eric to double-check all form elements.

Note, there are still problems laying out the test case.  These should be
submitted as separate bugs as well.

Comment 11

[Hixie (not reading bugmail)]

See also:
   bug 11537 Value of wallet.Server pref is blank until clicked on
   bug 18357 Legend align does not work in Japanese
   bug 21638 {css1} Cannot style FIELDSET element outside FORM elements

Comment 12

[vidur (gone)]

Passing this one along to pollmann per our conversation.

Comment 13

[ekrock's old account (dead)]

Bulk moving [testcase] code to new testcase keyword. Sorry for the spam!

Comment 14

[buster]

eric: if you're still waiting for a code review, you can give it a r=buster 
since I authored the patch.  If you agree it's the right fix, that's two of us 
(I guess really you'd be reviewing my fix, but it's best if you own this bug 
for obvious reasons.)  Get it in for M14?

Comment 15

[Eric Pollmann]

Yup, I'll get it in for M14, thanks for the patch!  :)

Comment 16

[daver]

but check it in if you have the fix

Comment 17

[Eric Pollmann]

Checked in.  Thanks for your excellent fix, Steve!  (Sorry this took so long)

Comment 18

[Jan Carpenter]

Mass update of qa contact

Comment 19

[Prashant Desale]

QA contact Update

Comment 20

[Prashant Desale]

Updating QA contact to Shivakiran Tummala.

Comment 21

[Sivakiran Tummala]

tested for the testcase ...looks fine

Comment 22

[Sivakiran Tummala]

does not work on windows 2000 for the build 2001-06-07-13-0.9.1

Comment 23

[Fabian Guisset]

Sivakiran could you test this again? Using win2k build 2001091203 I see the
correct behavior:
myform.id == myform
mylegend.form == [object HTMLFormElement]
mylegend.form.id == myform
Thanks.

Comment 24

[Sivakiran Tummala]

verified linux 092704

Comment 25

[Sivakiran Tummala]

verified on win2k 2001-10-17-18

Comment 26

[Sivakiran Tummala]

verified fixed, marking as verified

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7333cea5f76d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10434: Handle cases when proc/$pid/stat is not accessible.