1056950 - Welcome email should not be sent before email address is verified

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Sign-in, defect)

Description

[John Karahalis [:openjck]]

An account cannot be used while the associated email address is pending verification. The welcome email thanks the user for creating an account and recommends that the user begin contributing, so the welcome email should not be sent before the email address is verified.

Many users will verify their email addresses right away, but we still need to consider two cases: (1) the welcome email is delivered but the verification email is not, and (2) the user reads the welcome email before the verification email. In both cases, the user will be frustrated by being unable able to contribute as the welcome email suggests.

Comment 1

[John Karahalis [:openjck]]

Marking as major in the triage meeting because we feel that this message could be perceived as spam considering that it is sent incorrectly / early.

Comment 2

[Luke Crouch [:groovecoder]]

We need some reliable steps to reproduce. We suspect that it only happens if you sign up with GitHub using an un-verified email address that isn't verified on GitHub.

Regardless, we should move the welcome email to a signal after the account email is verified, rather than the signal when the user record is saved.

Comment 3

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: 2 emails in inbox

Steps to reproduce:

1) Add an unverified email address that is not associated with an MDN account to your (existing) github account
2) Sign in to MDN using Github; choose the email address from step #1
3) Both emails are sent at almost the same instant (see attachment)

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/94624039459215895bcd547f7ba3992321cdf1e6
fix bug 1056950 - only send welcome email when at least one email address is verified

This also delays sending the welcome email till after the initial email address confirmation has happened.

https://github.com/mozilla/kuma/commit/6ea0591c972bb8a437fbe7adf11409bd81e8c485
Merge pull request #2773 from jezdez/bug1056950

fix bug 1056950 - only send welcome email when at least one email address is verified