Closed
Bug 108528
Opened 23 years ago
Closed 21 years ago
"knob is not defined" error message does not help a user find the error
Categories
(Bugzilla :: Creating/Changing Bugs, defect, P3)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: timeless, Assigned: caduvall)
References
Details
Attachments
(1 file, 4 obsolete files)
991 bytes,
patch
|
justdave
:
review+
|
Details | Diff | Splinter Review |
Bugzilla Bug 108526 preSelected radio buttons in forms aren't preselected Please make the knob is not defined message suggest checking to see if ( ) Leave bug as ... is set.
Updated•23 years ago
|
Severity: normal → minor
Priority: -- → P3
Target Milestone: --- → Bugzilla 2.18
This adds the ability to submit a specific error message when checking for a blank cgi parameter, and adds a more useful error message for knob not existing.
Comment on attachment 133158 [details] [diff] [review] Add info field to Check FormFieldDefined Requesting review of bbaetz, as he and gerv seem to be the major reviewers/coders in the surrounding code.
Attachment #133158 -
Flags: review?(bbaetz)
Attachment #133158 -
Flags: review?(bbaetz) → review?(timeless)
Attachment #133158 -
Attachment is obsolete: true
Attachment #133159 -
Flags: review+
Attachment #133158 -
Flags: review?(timeless)
Updated•21 years ago
|
Flags: approval? → approval+
checked in
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 6•21 years ago
|
||
This patch makes the translation of the $info string very hard.
Comment 7•21 years ago
|
||
Indeed. I'm glad Tobias, at least, is on the ball. We either need a new cumulative patch which fixes that issue, or we need to back this one out and have another go at it. Gerv
Comment 8•21 years ago
|
||
It's been backed out. Checking in CGI.pl; /cvsroot/mozilla/webtools/bugzilla/CGI.pl,v <-- CGI.pl new revision: 1.208; previous revision: 1.207 done Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.194; previous revision: 1.193 done Checking in template/en/default/global/code-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-error.html.tmpl,v <-- code-error.html.tmpl new revision: 1.33; previous revision: 1.32 done Shall we try again?
Status: RESOLVED → REOPENED
Flags: approval+
Resolution: FIXED → ---
Thanks Tobias, Gerv. Still learning the ropes, feedback is welcome. Looking at what this bug depends on, the error message was spot on - there is a bug in your browser. Minimal patch to give a small bit more information, telling them that knob was a form field follows.
Status: REOPENED → ASSIGNED
Summary: knob is not defined doesn't explain to 2001110503 users what to do → knob is not defined error message does not help a user find the error
Assignee | ||
Comment 10•21 years ago
|
||
This just tweaks the default message slightly. The only place this error is thrown from is CheckDefinedFormField, and all callers are checking for, well, defined form fields. Low impact. I don't know if this enough for original reporter (timeless).
Attachment #133159 -
Attachment is obsolete: true
Attachment #133465 -
Flags: review?(timeless)
Attachment #133465 -
Flags: review?(gerv)
Assignee | ||
Comment 11•21 years ago
|
||
This satisifies timeless. It should meet translation requirements, as I understand them now.
Attachment #133465 -
Attachment is obsolete: true
Attachment #133471 -
Flags: review?(gerv)
Attachment #133465 -
Flags: review?(timeless)
Attachment #133465 -
Flags: review?(gerv)
Comment 12•21 years ago
|
||
I'd say: "Check that the "Leave as..." radio button was selected." Otherwise, fine. Gerv
Assignee | ||
Comment 13•21 years ago
|
||
Attachment #133471 -
Attachment is obsolete: true
Updated•21 years ago
|
Attachment #133471 -
Flags: review?(gerv)
Updated•21 years ago
|
Attachment #133603 -
Flags: review+
Updated•21 years ago
|
Flags: approval? → approval+
Updated•21 years ago
|
OS: Windows 98 → All
Hardware: PC → All
Updated•21 years ago
|
Summary: knob is not defined error message does not help a user find the error → knob is not a defined error message and it does not help a user find the error
Comment 14•21 years ago
|
||
Checking in code-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-error.html.tmpl,v <-- code-error.html.tmpl new revision: 1.34; previous revision: 1.33 done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
Updated•21 years ago
|
Summary: knob is not a defined error message and it does not help a user find the error → "knob is not defined" error message does not help a user find the error
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•