Open Bug 109682 Opened 23 years ago Updated 16 years ago

Tie DOM Inspector into the editor

Categories

(SeaMonkey :: Composer, enhancement)

Product:
SeaMonkey
Component:
Composer
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

People

(Reporter: roland.mainz, Unassigned)

References

Details

(Keywords: helpwanted, Whiteboard: composer++)

Attachments

(1 file)

First-look notes
5.20 KB, text/plain
Details 
RFE: make the "DOM Inspector" available to Mozilla's editor, maybe as 5th TAB
(e.g. "Normal", "Show All Tags", "<html> source", "DOM view", "Preview"...)
sorry, I don't think this figures into editor's plans
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX
AFAIK there is some spec (W3C ?! I am not sure... ;-( ) which recommendes that
there should be a way to edit the DOM view, too.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Roland, it's really inappropriate for anyone to reopen a bug the owner has
marked WONTFIX without a citeable reference or reason.

Personally I agree with you that this is a valuable feature.  Give me some time
to learn XUL and XBL, and I might take a stab at it personally.  (Read:  six
months, minimum -- almost certainly post-1.0.)

I'll leave remarking this WONTFIX up to Joe Hewitt.  However, if he's in the
mood, he can assign this to me and mark it LATER.  I'm willing to take the
effort, someday, to make the connection.

Might as well start learning how to fix bugs, anyway... :)
Severity: normal → enhancement
Summary: Plug the the "DOM Inspector" into the "editor"... → RFE: Tie DOM Inspector into the editor
Bah. Roland reported it, imo if hewitt doesn't intend to fix it, he can assign 
it to nobody.  I haven't actively discussed the policy for this component w/ 
him, but I'm QA and I would like to see this.  I'd like some comment from the 
editor people...
Keywords: helpwanted
Summary: RFE: Tie DOM Inspector into the editor → RFE: Tie DOM Inspector into the editor
If we're going to throw Inspector into Editor, I figure we'll want to be able to
create nodes, since it already allows deletion of them. If this opinion is
correct, than this depends on bug 112775.

Secondly, I figure this should be in component Editor: Composer, though I'm not
setting that. Heh, I'm probably wrong about that one, anyways. ;)
Depends on: 112775
DOM Inspector totally rocks, and we'd love to see it used by Composer.
I agree that being able to create nodes would be essential (bug 112775).
I don't have a good feeling for what's involved in doing this, and we are all
fairly committed to other tasks through the moz1.0 timeframe. But let's not 
forget this for future development.
This is an interesting idea, but I don't think I'll ever have the time to do it.
Assignee: hewitt → nobody
Status: REOPENED → NEW
Depends on: 112922
RFE as a summary keyword is deprecated, and besides, I'm tinkering around right 
now on the two bugs this one depends on.
Status: NEW → ASSIGNED
Summary: RFE: Tie DOM Inspector into the editor → Tie DOM Inspector into the editor
Depends on: 178583
assigning to alex vincent, which is probably what he meant to do when he marked
this bug as ASSIGNED
Assignee: nobody → ajvincent
Status: ASSIGNED → NEW
Sorry, I accepted the wrong bug.  I am not ready to take this one.
Assignee: ajvincent → nobody
Depends on: 179621
Attached file First-look notes — 
Took a quick look around Editor's XUL+JS files, and I think this attachment
describes a good starting point for adding Inspector to Editor.
Depends on: 201834
Question for the Editor guys:  do you want Inspector embedded by default into 
Editor, or would you prefer the user install it as a package?

For Netscape users, Inspector is provided as an installable package.
Another question for the _Netscape_ commercial-build Composer team:  how would 
you treat the Inspector component in regards to Editor?  If Inspector becomes 
an unconditional fifth panel, we'll need docs on it and timeless' 
internationalization bug would block this.  You'd also need a bug filed for 
doc'n of Inspector (probably something I'd write, with a cc to oeschger@n.c)
What the hey, I'll take it.  I'm probably going to be the point man working on
this anyway.  We'll need a new editorInspector.xul and editorInspector.js.

I'm not going to be able to work on this soon; there's too much other work
Inspector needs done to it first, as support work for this.  I'm thinking 1.6 at
the earliest.
Assignee: nobody → ajvincent
Component: DOM Inspector → Editor: Composer
Target Milestone: --- → mozilla1.6beta
No longer depends on: 178583
I firmly believe that a specific version of Document Inspector for Composer should
restrict the tree view to the HTML document and hide, as least in a default mode,
the XUL part of the tree above the HTML editor.

Alex: thanks for taking.
Agreed 100%, glazman:  exposing the parent XUL document is a very bad idea, for
no other reason than it would confuse the user.  (Besides, DOM Inspector
standalone can inspect the Editor window anyway.)

We may not be able to prevent the user from going to those higher levels,
though, through JSObject viewer and the properties of properties of the
inspected document, etc.

I'm still going to need help from Editor team; although I'm competent in
Inspector, Editor is not something I'm familiar with.  The first-look notes is
as far as I've gotten.
Okay, looks like I need to edit the following files as well:

editor/ui/composer/content/ComposerCommands.js#198
add a new command to same file, roundabouts lines 3213-3276

editor/ui/composer/content/editor.js#1882 adding lines for stylesheets for
Inspector mode

editor/ui/composer/content/editor.xul#251 -- this thing's going to need an
entirely new content window...
FYI: I support making this an integrated part of the Composer app, i.e., part of
any new, separate Composer module. It should be another "Edit view" or tab along
with the exiting 4.
Depends on: 212815
Product: Browser → Seamonkey
This very clearly is not going to happen, at least not the way I had intended.  N|Vu has their own implementation of DOM-I, and if/when that lands, this bug will become obsolete... :(
Assignee: ajvincent → composer
QA Contact: timeless
Assignee: composer → nobody
QA Contact: composer
Target Milestone: mozilla1.6beta → ---
You know, if N|Vu uses the Gecko 1.9 toolkit and provides a tools menu, then this bug is probably fixed - DOM-I supports the toolkit@mozilla.org application target.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: