110215 - module specific optimizations

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[hacker formerly known as [e-mail]]

I was thinking about alternatives to bug 53486, which is hung up on compiler
issues, and I came up with a method to allow module owners to increase the
default optimization level for their module.  Afaik, there shouldn't be any
problems mismatching optimization levels across files much less modules.

Comment 1

[hacker formerly known as [e-mail]]

Attachment: Use MODULE_OPTIMIZE_FLAGS to override *default* optimization

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Would bug 53486 be less hung up if we built js/src with -fno-strict-aliasing?

Comment 3

[hacker formerly known as [e-mail]]

I don't believe so.  Most of the problems that I saw with -O2 builds dealt with
nsCOMPtrs and presumably how templates are optimized by egcs.  The declaring a
nsCOMPtr inside a while loop is still occassionally causing problems with gcc
2.95.x builds.

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 57886 [details] [diff] [review]
Use MODULE_OPTIMIZE_FLAGS to override *default* optimization

r=bryner

Comment 5

[hacker formerly known as [e-mail]]

Checked in.