Closed
Bug 110980
Opened 23 years ago
Closed 22 years ago
no email to CC list when opening new bug
Categories
(Bugzilla :: Email Notifications, defect, P2)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: mozilla-org, Assigned: jacob)
References
()
Details
Attachments
(1 file, 2 obsolete files)
2.22 KB,
patch
|
gerv
:
review+
justdave
:
review+
|
Details | Diff | Splinter Review |
In the user preferences in section "When I'm on the CC list, email me" I check "When I'm added to or removed from this capacity" and I uncheck "New Comments". If someone else puts me in the CC list when opening a new bug, I won't get email. Expected result, however, is that I get email because I have been added to the capacity "being on CC list". If I get added to CC list lateron, or if I check "New Comments", then emailing works fine.
Reporter | ||
Updated•23 years ago
|
Version: 2.14 → 2.15
Updated•23 years ago
|
Priority: -- → P2
Target Milestone: --- → Bugzilla 2.16
Comment 1•23 years ago
|
||
no patch, not a blocker, -> 2.18
Target Milestone: Bugzilla 2.16 → Bugzilla 2.18
Comment 2•23 years ago
|
||
*** Bug 125169 has been marked as a duplicate of this bug. ***
Comment 3•23 years ago
|
||
We need to also check the assignee and QA, plus reporter when the "my changes" setting is on.
Assignee | ||
Comment 4•23 years ago
|
||
This makes post_bug.cgi use the same method of "tricking" processmail that process_bug.cgi does.
Assignee | ||
Comment 5•23 years ago
|
||
Moving this back down to 2.16, but still not a blocker.
Comment 6•22 years ago
|
||
Comment on attachment 69250 [details] [diff] [review] Patch >+my $CcString = ""; > foreach my $person (keys %ccids) { > SendSQL("insert into cc (bug_id, who) values ($id, $person)"); >+ $CcString .= $ccids{$person}; > } Don't you need to separate those by a comma or a space? I won't mark needs work because I haven't tested this yet, though.
Assignee | ||
Comment 7•22 years ago
|
||
Yes, if there's more than one value it does have to comma seperate them... silly me, I only tested w/one user :)
Attachment #69250 -
Attachment is obsolete: true
Comment 8•22 years ago
|
||
just to double-check here, I seem to recall a patch that Myk did that totally redid the mail preferences checking... I don't recall if it's been checked in or not though. Would that negate the need for this? (since it was almost a total rewrite, seems like it may have fixed it on accident)
Comment 9•22 years ago
|
||
Comment on attachment 74580 [details] [diff] [review] Patch v2 OK, this WFM. r=bbaetz if you add the -forcereporter option to the help message just below
Attachment #74580 -
Flags: review+
Comment 10•22 years ago
|
||
Changing default owner of Email Notifications component to JayPee, a.k.a. J. Paul Reed (preed@sigkill.com). Jake will be offline for a few months.
Assignee: jake → preed
Status: ASSIGNED → NEW
Comment 11•22 years ago
|
||
changing owner back to Jake for the record books because he wrote the patch for this one.
Assignee: preed → jake
Comment 12•22 years ago
|
||
Just out of curiosity, what circumstances would allow me to reproduce this? I'm unable to duplicate the symptoms of this bug on the tip. I can create a new bug and everybody I put on the CC list gets mailed.
Comment 13•22 years ago
|
||
See comment 0 - if you have your email prefs set so that you only get notified on add/remove, not comments, then you won't get mail if you're ccd when a new bug is created.
Comment 14•22 years ago
|
||
Comment on attachment 74580 [details] [diff] [review] Patch v2 >- $ccids{DBNameToIdAndCheck($person)} = 1; >+ $ccids{DBNameToIdAndCheck($person)} = $person; ... >+my @Cc; > foreach my $person (keys %ccids) { > SendSQL("insert into cc (bug_id, who) values ($id, $person)"); >+ push(@Cc, $ccids{$person}); Huh? Why not nuke the first change, then just do: >+ push(@Cc, $person); ? And can we call it @cc, please - @Cc looks weird. >+if ($#ARGV >= 0 && $ARGV[0] eq "-forcereporter") { >+ shift(@ARGV); >+ @{$force{'Reporter'}} = trim(shift(@ARGV)); >+} >+ > if (($#ARGV < 0) || ($#ARGV > 1)) { > print "Usage:\n processmail {bugid} {nametoexclude} " . > "[-forcecc list,of,users]\n [-forceowner name] " . ></PRE></BODY></HTML> This method of command-line processing sucks a bit; if we are going to force the options to be in a certain order, why do we bother labelling them with "-force*"? Gerv
Attachment #74580 -
Flags: review-
Comment 15•22 years ago
|
||
gerv: one is an id, the other is an email address. The two are only equivalent iff |DBNameToIdAndCheck($person) = $person|, which is obviously not true. Yes, commandline processing sucks. Thats a separate bug, though - see bug 92276, plus bug 124174.
Comment 16•22 years ago
|
||
Comment on attachment 74580 [details] [diff] [review] Patch v2 Doh. OK. :-) r=gerv. Gerv
Attachment #74580 -
Flags: review- → review+
Comment 17•22 years ago
|
||
Fixed cvs conflicts because of the templatisation. gerv, can you review again, please?
Attachment #74580 -
Attachment is obsolete: true
Comment 18•22 years ago
|
||
Comment on attachment 78137 [details] [diff] [review] patch You seem to have made the change I suggested which you then said was bogus. What is going on there? Gerv
Comment 19•22 years ago
|
||
the templatisation merged the two loops - we can use $person directly, rather than storing it in the hash and pulling it out later. In the orignal patch, $person was referring to different things each time. Firstly as a name, then as the keys of the hasah, which is an id. Here the combined loop just uses the email addr as $person, and $ccid as the id.
Comment 20•22 years ago
|
||
Comment on attachment 78137 [details] [diff] [review] patch Right. No wonder the old code had me confused. :-) r=gerv. Gerv
Attachment #78137 -
Flags: review+
Comment 21•22 years ago
|
||
Comment on attachment 78137 [details] [diff] [review] patch ok, makes much better sense to me now. r= justdave
Attachment #78137 -
Flags: review+
Comment 22•22 years ago
|
||
Checked in: Checking in post_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v <-- post_bug.cgi new revision: 1.45; previous revision: 1.44 done Checking in processmail; /cvsroot/mozilla/webtools/bugzilla/processmail,v <-- processmail new revision: 1.81; previous revision: 1.80 done
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•