111242 - All Menu item calls not happening

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Tracy Walker [:tracy]]

seen on mac commercial and mozilla builds: 2001-11-21-08-trunk

-Launch the app
-attempt to use any item through Menu drop down lists
None work.... however if there is a keyboard shortcut of corresponding icon (ie 
mail), those work.  Workaround exists, but still making this a blocker.

Comment 1

[Tracy Walker [:tracy]]

sorry, Asa, I know how much you dislike me putting smoketest blockers under 
browser-general.

Comment 2

[Tracy Walker [:tracy]]

Actually, there aren't keyboard shortcuts or icons to get to such things as 
Preferences, Privacy & Security...etc.  Definitely a smoketest blocker!!

Comment 3

[(not reading, please use [e-mail] instead)]

I've got a mac debug build from last night (around 11 pm), I'll see if that
shows this problem.

Comment 4

[(not reading, please use [e-mail] instead)]

I see this problem on a build from last night.

Comment 5

[(not reading, please use [e-mail] instead)]

this broke sometime before 9:25 pm, last night.

Comment 6

[(not reading, please use [e-mail] instead)]

pink says this worksforhim, from a build from yesterday at 3 pm.

Comment 7

[(not reading, please use [e-mail] instead)]

setting some breakpoints in the mac menu code, at nsMenuItem::DoCommand()

if I don't come back in a 20 minutes, send someone in after me.

Comment 8

[(not reading, please use [e-mail] instead)]

nsMenuItem::nsMenuItemSelected() isn't getting called.
neither is nsMenuItem::DoCommand().

I'm assuming that's bad, but I don't know the mac menu code.

Comment 9

[(not reading, please use [e-mail] instead)]

nsMacEventHandler::HandleMenuCommand() isn't getting called, either.

Comment 10

[sairuh (rarely reading bugmail)]

...reassign as needed.

Comment 11

[(not reading, please use [e-mail] instead)]

DispatchMenyCommandToRaptor() is getting called, in nsMacMessagePump.cpp.

pink and I are debugging...

Comment 12

[(not reading, please use [e-mail] instead)]

a file was moved (recently?)

and USE_MENUSELECT is not #defined in nsMacMessageSink.cpp

that horks nsMacMessageSink::DisplatchMenuCommand()

working on the fix with pink...

Comment 13

[(not reading, please use [e-mail] instead)]

Index: WidgetSupportConfig.h
===================================================================
RCS file: /cvsroot/mozilla/widget/macbuild/WidgetSupportConfig.h,v
retrieving revision 1.1
diff -u -2 -r1.1 WidgetSupportConfig.h
--- WidgetSupportConfig.h	2001/11/10 01:00:45	1.1
+++ WidgetSupportConfig.h	2001/11/21 19:37:58
@@ -2,2 +2,6 @@
 
 #define _IMPL_NS_WIDGET 1
+
+#if !TARGET_CARBON
+#define USE_MENUSELECT 1
+#endif

there's the fix that pink gave me.  it works.  checked in.

Comment 14

[Simon Fraser [no longer active]]

Sorry folks, this was my fault. WidgetSupportConfig.h is the right place for the
#define. sr=sfraser n' all that.

Comment 15

[sairuh (rarely reading bugmail)]

menus now working. vrfy fixed using 2001.11.21.12-comm bits on os 9.1.