1128367 - syntax errors in some of the test shell scripts

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[Elio Maldonado]

Attachment: Fixes shell syntax errors in some shell scripts

all.sh, cipher.sh and dbtest.sh contanis syntax errors in some of their comparisons.
In all.sh
if [ ${NSS_BUILD_SOFTOKEN_ONLY} -eq "1" ]; then
should be
+if [ ${NSS_BUILD_SOFTOKEN_ONLY} = "1" ]; then

In cipher.sh
 if [ ! -x ${DIST}/${OBJDIR}/bin/bltest${PROG_SUFFIX} ]; then
     echo "bltest not built, skipping this test." >> ${LOGFILE}
    res = 0 <----- spaces  
caused Red Hat tools to complain "error: cannot find the res command"
It should be changed to
    res=0
For dbtest two if [$UID -ne 0] then statments are missing ";"
Fix is
-    if [ $UID -ne 0 ] then
+    if [ $UID -ne 0 ]; then
This one is also deteected by the shell
$ sh -n tests/dbtests/dbtests.sh 
tests/dbtests/dbtests.sh: line 181: syntax error near unexpected token `else'
tests/dbtests/dbtests.sh: line 181: `    else'

Comment 1

[Elio Maldonado]

Attachment: Fixes shell syntax errors in some shell scripts

add a fix for common/init.sh to the previous one.

Comment 2

[Kai Engert (:KaiE:)]

Comment on attachment 8557722 [details] [diff] [review]
Fixes shell syntax errors in some shell scripts

r=kaie

Comment 3

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/projects/nss/rev/e8d9e0ebf355