1140091 - Incorrect "Compare on MDN" link in first-edit email on a new page

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect)

Description

[Eric Shepherd [:sheppy]]

What did you do?
================
1. Got a first-edit email notification on the page 
2. Opened the email
3. Found that the link for "Compare on MDN" was not to the right place, but instead to the home page

What happened?
==============
I will attach a screenshot momentarily.

What should have happened?
==========================
This link should be valid, or not present if there is no prior version; the text "New page" should be presented somewhere instead.

Is there anything else we should know?
======================================

Comment 1

[Eric Shepherd [:sheppy]]

Attachment: Screenshot of the first-edit message in question

Presumably this happened because it's a new page, so there is no prior version. But this is not the appropriate output for that scenario.

Comment 2

[Justin Crawford [:hoosteeno] [:jcrawford]]

Let's find a meta bug for this -- there are a handful of minor changes to formatting and content of the "first edit email" that we can make all at once.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/1dbd4d87e1a9cc935ce8c3b6451382eed24edb12
fix bug 1140091: Omit Compare link for new pages

https://github.com/mozilla/kuma/commit/4cdf4b01e623c804edbd84edf181580a71f18518
Merge pull request #4193 from jwhitlock/compare_link_1140091

fix bug 1140091: Omit Compare link for new pages

Comment 4

[John Whitlock [:jwhitlock]]

Pushed to stage and production, link will be correct going forward.