Closed
Bug 120901
Opened 23 years ago
Closed 23 years ago
XPCWrappedNative::GetNative() wastes time QI'ing to nsISupports.
Categories
(Core :: XPConnect, defect, P2)
Core
XPConnect
Tracking
()
VERIFIED
FIXED
mozilla0.9.9
People
(Reporter: jst, Assigned: jst)
Details
(Keywords: perf, Whiteboard: [HAVE FIX])
Attachments
(1 file)
|
858 bytes,
patch
|
dbradley
:
review+
jband_mozilla
:
superreview+
|
Details | Diff | Splinter Review |
When XPCWrappedNative::GetNative() is called, the code already has a pointer (mIdentity) to the correct vtable in the native pointer, so the QI to nsISupports is not needed. Patch coming up.
|
Assignee | |
Comment 1•23 years ago
|
||
Reviews?
|
|
Assignee | |
Updated•23 years ago
|
Status: NEW → ASSIGNED
Keywords: perf
Priority: -- → P2
Whiteboard: [HAVE FIX]
Target Milestone: --- → mozilla0.9.9
|
||
Comment 2•23 years ago
|
||
Comment on attachment 65741 [details] [diff] [review] Don't QI to nsISupports when we already have a mIdentity pointer. sr=jband How'd I leave that in?
Attachment #65741 -
Flags: superreview+
|
||
Comment 3•23 years ago
|
||
Comment on attachment 65741 [details] [diff] [review] Don't QI to nsISupports when we already have a mIdentity pointer. r=dbradley
Attachment #65741 -
Flags: review+
|
|
Assignee | |
Comment 4•23 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•