Closed Bug 121234 Opened 23 years ago Closed 21 years ago

In <chrome://global/content/bindings/tabbrowser.xml>, "Error: this.mMissedIconCache has no properties"

Categories

(SeaMonkey :: Tabbed Browser, defect)

Product:
SeaMonkey
Component:
Tabbed Browser
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Future

People

(Reporter: timeless, Assigned: jag+mozilla)

References

(
URL
)

Details

(Keywords: helpwanted, testcase)

Attachments

(2 files, 2 obsolete files)

testcase
256 bytes, text/html
Details
Addressed timeless' comment
2.76 KB, patch
timeless
: review+
jag+mozilla
: superreview+
Details | Diff | Splinter Review 
Error: this.mMissedIconCache has no properties
Source File:
chrome://global/content/bindings/tabbrowser.xml#tabbrowser.addToMissedIconCache()
Line: 2
 <method name="addToMissedIconCache">
<parameter name="aURI"/>
<body>
<![CDATA[
            var entry = this.mMissedIconCache/*null*/.openCacheEntry(aURI,
Components.interfaces.nsICache.ACCESS_READ_WRITE, true);
            if (entry.accessGranted == Components.interfaces.nsICache.ACCESS_WRITE)
              // It's a new entry.  Just write a bit of metadata in to the entry.
              entry.setMetaDataElement("Icon", "Missed");
            entry.markValid();
            entry.close();
          ]]>

i'll provide a basic fix.
before i do that, people probably want some idea of why whatever is happening...

i'm a newbie to venkman, .. i set breakpoints near the addTo... call site as
best as it would allow me...

Stopped for breakpoint.
function anonymous(aWebProgress=XPComponent:{4}, aRequest=XPComponent:{24},
aStatus=double:2152398851, aMessage=string:"Resolving host
kevxml2a.infospace.com...") in
<chrome://global/content/bindings/tabbrowser.xml#tabbrowser.mTabProgressListener()>
line 92

Properties of this in debug target scope:
[e] mTabBrowser = [XULElement] [class: XULElement] {14}
[e] mTab = [XULElement] [class: XULElement] {1}
[e] mBlank = [boolean] false
[e] mIcon = [string] ""
[e] onProgressChange = [function] [class: Function] anonymous
[e] onStateChange = [function] [class: Function] anonymous
[e] onLocationChange = [function] [class: Function] anonymous
[e] onStatusChange = [function] [class: Function] anonymous
[e] onSecurityChange = [function] [class: Function] anonymous
[e] QueryInterface = [function] [class: Function] anonymous
Properties of this.mTabBrowser in debug target scope:
[e] mTabBox = [XULElement] [class: XULElement] {1}
[e] mStrip = [XULElement] [class: XULElement] {0}
[e] mTabContainer = [XULElement] [class: XULElement] {1}
[e] mPanelContainer = [XULElement] [class: XULElement] {0}
[e] mStringBundle = [XULElement] [class: XULElement] {1}
[e] mCurrentTab = [XULElement] [class: XULElement] {1}
[e] mCurrentBrowser = [XULElement] [class: XULElement] {1}
[e] mProgressListeners = [Array] [class: Array] {2}
[e] mTabListeners = [Array] [class: Array] {3}
[e] mTabbedMode = [boolean] true
[e] mIsBusy = [boolean] true
[e] mMissedIconCache = [null] null
[ep] onxblconstructor = [function] [class: Function] onxblconstructor
[ep] onclick = [function] [class: Function] onclick

fwiw this appeared in my jsconsole, so i think we really did hit it.
Error: this.mMissedIconCache has no properties
Source File:
chrome://global/content/bindings/tabbrowser.xml#tabbrowser.addToMissedIconCache()
Line: 2

i'm passing off to neil, since he thinks he can explain it...
My explanation is that when the document contains a favicon link, then the tab
image src is set directly by line 200, without checking that the URL is in the
missed icon cache, and thus bypassing the creation of the cache.

One possibility is to move the calls to buildFavIconString into the arguments of
the calls to loadFavIcon which could then be used for favicon links.
-> future, helpwanted

As with all these bugs, if you think you can fix it, please do take it off of my
hands :-)
Keywords: helpwanted
Target Milestone: --- → Future
I experienced this on build 2002040303 on Windows XP, changed OS to match:

Error: this.mMissedIconCache has no properties
Source File:
chrome://global/content/bindings/tabbrowser.xml#tabbrowser.addToMissedIconCache()
Line: 2
OS: Windows 98 → All
All means multiple platforms. Win32 is one platform, if I (or someone else) 
reproduce(s) this on my[/their] freebsd box and then I can mark it all.

the algorithm that I use for os's per platform is to pick the oldest that 
reproduces a bug, so in this case my w98 trumps your (or my) w2k.
OS: All → Windows 98
Adding to comment #6:
This happens even when I am not using tabbed browsing.
I have these errors on Solaris2.6. It seems to be an OS-generic bug.
I am setting OS to all for comment #8.
OS: Windows 98 → All
URL mentioned in comment #6 is 404 now. 

I'm getting this error on http://duffy.sk/knp/klub_priatelov.html
Problem IMHO occurs if (shortcut) icon is 404. I'll attach testcase.
Keywords: testcase
Attached file testcase — 
QA Contact: sairuh → pmac

    
    

    
  
Encountered using FizzillaCFM/2002101808. Setting Platform=All.
Hardware: PC → All

    
    

    
  
*** Bug 177869 has been marked as a duplicate of this bug. ***

    
    

    
  
well, i hesitate to do this, but this is the only site i've seen cause this bug
reliably.  it is an adult dvd rental site, so if you're underage or easily
offended, don't go.  http://www.wantedlist.com/DetailList.asp?TITLE_ID=1295 
click on buy, rent, larger image front or back, which will pop up a new window
and spew forth multiple missed icon cache errors.  url and testcase from comment
10 and comment 11 don't seem to cause the bug for me.  (mozilla 1.2.1, mac os
x.)  happens both with tabs and without.

    
    

    
  
This bug occurs for me using the web system we sell (hence passworded - sorry).

The only thing I can think that it might be is that we use dreamweaver's
mm_preload_image code on page loadup. Usually without any parameters (duh!) :)

build 2003031216 and since at least 1.3 beta

    
    

    
  
I'm so silly.
I use Mozilla without tabs and ALWAYS without quicklaunch, on windows 2000.
apologies for double-posting that information

    
    

    
  
*** Bug 197718 has been marked as a duplicate of this bug. ***

    
    

    
  
Error: this.mMissedIconCache has no properties
Source File:
chrome://global/content/bindings/tabbrowser.xml#tabbrowser.addToMissedIconCache()
Line: 2

This error message occurs on every web page I open and even on simple files on
my desktop. I get it whether I am online or off. It doesn't matter if I use
tabbed browsing or not.

The javascript console is always cluttered with multiple copies of this error
message.

    
    

    
  
[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4a) Gecko/20030401]

Another URL, allways reproductible: <https://interactif.creditlyonnais.fr/>.
(Actually, I often get this error 2-3 times at once.)

Like others, I get the error even with 1 (== "no") Tab. (I do use Tabs otherwise.)


As pointed out, the culprit seems to be:
[
<link REL="SHORTCUT ICON" HREF="/favicon.ico">
]

The favIcon placeholder on the left of the tab remains "blank".
Nevertheless, this file exists and is *not* "HTTP 404";
<https://interactif.creditlyonnais.fr/favicon.ico> does load it, but (defaults
to) as "text/html" !


As a comparison, the following line is extracted from this bug page:
[
<link rel="icon" href="http://mozilla.org/images/mozilla-16.png" type="image/png">
]

Notice, in the "bad" line, that the 'rel' value is different, and the 'type'
attribute is missing, besides the '.ico' instead of the '.png' format.


Now, I'll let you use theses clues;
and I'll report it to this site admin, along with 2 errors on '.css' without
explicit 'text/css' type... :-(


    
    

    
  
I suggest to change the summary to:

In <chrome://global/content/bindings/tabbrowser.xml>, "Error:
this.mMissedIconCache has no properties"

Summary: Error: this.mMissedIconCache has no properties → In <chrome://global/content/bindings/tabbrowser.xml>, "Error: this.mMissedIconCache has no properties"

    
    

    
  
[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4b) Gecko/20030507]

Bug still there. (with v1.3 profile, at least)


    
    

    
  
serge, no need to post "bug is still there" comments. 
http://bugzilla.mozilla.org/page.cgi?id=etiquette.html

although, as long as you are, please tell us what site is still causing the bug.
 credit lyonnaise seems to work okay.

all the testcases and links do not produce a mMissedIconCache error for me now
(mozilla firebird nightly 20030519), although wantedlist popups generate a new
error for me now. :(

    
    

    
  
Re comment 22:

[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4b) Gecko/20030507]

Comment 21 is about comment 19;
Bug still occurs tonight = error yes icon no.

But, since I'm not using nightlies, it may have been fixed in the meantime !?
(Next upgrade for me should be "v1.4rc1".)


    
    

    
  
my 2p worth

<link rel="icon" href="http://www.doesnotexist/favicon.ico" />

causes this error to occur on 1.4 rc1 (win2k).

I removed the line and lo the error stopped occurring.

Don't know it that helps, but I hope it helps someone.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        clone init code (obsolete)
        — 
          — Splinter Review
      

    


  

    
  

        Attachment #125824 -
        Flags: superreview?(jaggernaut)

        Attachment #125824 -
        Flags: review?(neil.parkwaycc.co.uk)

    
    

    
  
Comment on attachment 125824 [details] [diff] [review]
clone init code

Instead of duplicating that code, shouldn't you move it out into a field /
property+getter pair?

        Attachment #125824 -
        Flags: superreview?(jaggernaut) → superreview-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Proposed patch (obsolete)
        — 
          — Splinter Review
      

    


  

    
  

        Attachment #127438 -
        Flags: superreview?(jaggernaut)

        Attachment #127438 -
        Flags: review?(timeless)

    
    

    
  
Comment on attachment 127438 [details] [diff] [review]
Proposed patch

please change as discussed

        Attachment #127438 -
        Flags: superreview?(jaggernaut)

        Attachment #127438 -
        Flags: review?(timeless)

        Attachment #127438 -
        Flags: review-

    
    

    
  


  

        Attachment #127438 -
        Attachment is obsolete: true

    
  

        Attachment #127460 -
        Flags: superreview?(jaggernaut)

        Attachment #127460 -
        Flags: review?(timeless)

    
  

        Attachment #127460 -
        Flags: review?(timeless) → review+

    
    

    
  
Comment on attachment 127460 [details] [diff] [review]
Addressed timeless' comment

sr=jag

        Attachment #127460 -
        Flags: superreview?(jaggernaut) → superreview+

    
    

    
  
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED

    
  

        Attachment #125824 -
        Attachment is obsolete: true

        Attachment #125824 -
        Flags: review?(neil.parkwaycc.co.uk)
Product: Core → SeaMonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: