121325 - autocompletion during openWebLocation doesn't use tabScrolling

Status: NEW

(SeaMonkey :: Autocomplete, defect)

Description

[Chris B. Sears]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.7) Gecko/20011221
BuildID:    2001122108

autocompletion during openWebLocation doesn't work.
Instead of navigating to the first entry on the autocompletion popdown
it just changes input focus or something.
The tabScrolling boolean isn't set.

Reproducible: Always
Steps to Reproduce:
1. open up the Open Web Location dialog
2. start typing a url.
3. an autocompletion menu popdown appears
4. press tab to navigate to the first entry.  It doesn't.

Actual Results:  It changes input focus?

Expected Results:  navigate to the first entry on the autocompletion list.

tabScrolling is by default false.  I did a global search
for tabScrolling and only found it explicitly set to true in the
navigator url bar.  Whomever looks at this bug might also
look at all other instances of autocompletion tabScrolling
and make sure they do the correct thing.

here is a patch file for xpfe/communicator/resources/content/openLocation.xul:

--- openLocation.xul.orig	Tue Jan 22 15:39:15 2002
+++ openLocation.xul	Tue Jan 22 15:39:53 2002
@@ -59,7 +59,7 @@
       <hbox align="center">
<textbox id="dialog.input" flex="1" type="autocomplete"
                   searchSessions="history" timeout="50" maxrows="6"
-                  oninput="doEnabling();">
+                  tabScrolling="true" oninput="doEnabling();">
<menupopup id="ubhist-popup" class="autocomplete-history-popup"
                      popupalign="topleft" popupanchor="bottomleft"
                      onpopupshowing="createUBHistoryMenu(event.target);"

Comment 1

[Oliver Klee]

Confirming on 2002011503 Win2k.

Comment 2

[Chris B. Sears]

Attachment: patch file, same as before but submitted as an attachment

the patch is the same as before but submitted as an attachment

Comment 3

[Joe Hewitt (gone)]

I could swear there was some reason why we didn't do this.  I think people
preferred that tab take them to the next dialog element. mpt, what say ye?

Comment 4

[Chris B. Sears]

> I think people preferred that tab take them to the next dialog element.

This is in the Open Web Location dialog and the next dialog element
is Choose File... which has its own menu item and command key.
So someone does OWL, types in "moz" and then tabs over to Choose File?

Anyways, tab to navigate on the URL list is what the browser URL bar does
and quoting Unity of Interface, "The same interface for the same task,
regardless of how the service is implemented on the other end."

Chris

Comment 5

[Blake Ross]

changing qa to claudius.

Comment 6

[scottputterman]

Moving Netscape owned 0.9.9 and 1.0 bugs that don't have an nsbeta1, nsbeta1+,
topembed, topembed+, Mozilla0.9.9+ or Mozilla1.0+ keyword.  Please send any
questions or feedback about this to [e-mail].  You can search for
"Moving bugs not scheduled for a project" to quickly delete this bugmail.

Comment 7

[Chris B. Sears]

On the Macintosh OS X port, the autocompletion in the main URL bar
has the desired behavior.

If I type in sla slashdot.org shows up in the autocompletion list.
If I type in sla<tab> it moves to the first entry.

IE autocompletes on the URL line and you just type return
which is rather nice.  sla<return> and you're there
instead of sla<tab><return>

Comment 8

[cutterjohn]

Would very much like to see this fixed.

(In reply to comment #4)
> Anyways, tab to navigate on the URL list is what the browser URL bar does
> and quoting Unity of Interface, "The same interface for the same task,
> regardless of how the service is implemented on the other end."

Comment 9

[Arun Prasannan (polar)]

Tab navigates to the first entry here (trunk).