121712 - sortStaticsLast is broken in trunk.

Status: VERIFIED FIXED

(Core Graveyard :: RDF, defect, P3)

Description

[Suresh]

bz's checkin to nsXULSortService broke the sortStaticsLast functionality. 

Backing out's bz's checkin (version 1.141) fixes the problem.

Comment 1

[Chase Tingley]

I'm not quite sure at a glance why this would cause it, but it may have been
this change near line 1922 to nsXULSortService.cpp in bz's patch to bug 100649:

-
		if (id.Length() > 0)
+
		if (id.IsEmpty())
 
		{

This appears to invert the intended truth statement.

Comment 2

[scalkins]

This affects IM in commercial.
Nominating nsbeta1 
All platforms

Comment 3

[Chris Waterson]

Attachment: fix, based on tingley's analysis

Yeah, tingley was right.

Comment 4

[Chase Tingley]

Comment on attachment 66369 [details] [diff] [review]
fix, based on tingley's analysis

r=tingley

Comment 5

[Chris Waterson]

Fix checked in.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Doh.  Sorry about that... :(  I thought I'd checked all the changes in that
patch....

Comment 7

[Tom Everingham]

verified fix checked in