Closed Bug 122242 Opened 23 years ago Closed 23 years ago

comment parentMsgFolder in nsIMsgFolder.idl, check callers of GetParentMsgFolder for null out param.

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sspitzer, Assigned: naving)

Details

for bug #121876, bienvenu checked in:

nsCOMPtr <nsIMsgFolder> parentMsgFolder;                                      
rv = aFolder->GetParentMsgFolder(getter_AddRefs(parentMsgFolder));            
NS_ENSURE_SUCCESS(rv,rv);                                                     
+if (!parentMsgFolder)                                                         
+  return NS_OK;          
 
this was recently added to the nsIMsgFolder interface:

  /* handy accessor when we want a msg folder */
  readonly attribute nsIMsgFolder parentMsgFolder;

we should:

1)  extend that comment to specify that if the folder doesn't have a parent, it 
can return null.  (does that happens when we call GetParentMsgFolder on a root 
folder, right?)

2)  check the other callers (C++ and js) to make sure they handle this case 
correctly.

I'll spin up a new bug on this.
why to add such a comment. Isn't it a very basic thing that rootFolder doesn't have 
any parent. I did check other callers for changes I made. I will look it up
once more. 
OS: Windows 2000 → All
QA Contact: esther → stephend
Hardware: PC → All
I have checked - other callers are checking for null parentFolder except 
for one instance where parent cannot be null. 
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Taking Navin's word for this...verified.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.