12347 - Duplicate password dialogs for multiple pop accounts with biff set to true

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[esther]

Using build 1999082016 on win98, 19990816 on linux and 19990816 on mac user will
receive a duplicate password dialogs for each pop account when the biff time has
been reached twice.

Set your preference to have (2) pop accounts with biff set at 1 minute. Don't
have them set to remember password.

1. Launch Messenger
2. Wait 3 minutes, ignoring the password dialogs.
3. After 3 minutes, Clicking Cancel on the password dialog for your 1st pop
account will result in the 2nd pop password dialog to come up, then a
reappearance of both of these dialogs again.  Click Cancel for each and your
finally done.

Expected= the dialogs is dismissed with the 1st Cancel
Result= the dialogs pop up again

Comment 1

[Scott MacGregor]

Oh I know what's going on here...or at least I think I do.

If your biff interval is set to 1 minute and you wait 3 minutes...putterman's
biff code is going to tell me to get new mail every minute (so he'll tell me to
do it 3 times in this example). So you should see 3 prompt for password dialogs
come up on your screen. Canceling the first one, still leaves two more.

Can you verify that for me? Try canceling the other 2 and see if anymore come up
before the next biff interval.

Ideally, I think we'll only be running biff if you have remember password turned
on so you'll never get prompted anyway.

That may be how I'll fix this bug (by implementing remember password).

Comment 2

[scottputterman]

Yes.  We should only biff if the password is known.  Perhaps I should check
before doing a biff?  In our current state, biff would only work after logging
on in GetNewMsg.

Comment 3

[Scott MacGregor]

Scott, if you could do that, it would be the fastest way to fix this problem.
Every time the biff interval goes off, ask the server for the password...if it
is null or an empty string, don't do anything else...otherwise try getting new
mail.

Does that sound okay to you?

Comment 4

[scottputterman]

yeah, that sounds good to me.

Comment 5

[Scott MacGregor]

Scott, I'm assuming this code change would be going in the biff manager. Another
possibility involves me checking for password inside the pop3 service when you
ask it to check for new mail.

I'm ambivalent as to where we put it. I'll re-assign it to you if we put it in
the biff manager. Otherwise it should stay with me.

Comment 6

[scottputterman]

I have a fix for this.  reassigning to me.  I won't biff if there's no password.

Comment 7

[scottputterman]

A password dialog will no longer come up on biff. This means that if you wish to
see biff you will have to do a GetMessages so that you can log on (cc'ing
fenella for this last statement since she's tested biff in the past).  Until we
know your password, no biff will happen.

Comment 8

[esther]

Using 1999090109 M10 on win and 1999090108 on Mac and Linux, this is fixed.
Verified.