1265151 - Missing translation of some strings

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Localization, defect)

Description

[Victor Bychek]

What did you do?
================
Open "Revision Dashboard" or editing/translating of any article

What happened?
==============
We won't see translation of some strings

What should have happened?
==========================
We would like to see translated ones

Is there anything else we should know?
======================================

Comment 1

[MDN Team (:mdn-dev)]

Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/16c6d60cfb041d30e3f5a50e9fd2e06b9e86e3c5
Merge pull request #3838 from bychek-ru/bychek-ru-patch-1

Bug 1265151 - Missing translation of some strings

Comment 2

[MDN Team (:mdn-dev)]

Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/895215436aefa564144f4efd14d93bea7aaf0903
Merge pull request #3839 from bychek-ru/master

Bug 1265151 - Missing translation of some strings

Comment 3

[Victor Bychek]

I added localization for two missing strings 'Thanks for your feedback!' and "We won't bug you again." in helpfulness.js. https://github.com/mozilla/kuma/pull/3878

Comment 4

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/ee3db38ab680617dc0d1d80501cca5b5cfcd1070
Fix bug 1265151 - Missing translation of some strings

I added localization for strings 'Thanks for your feedback!' and "We
won't bug you again."

https://github.com/mozilla/kuma/commit/bf09ac1b35558f279fff1dd883d9cc130b650af2
Fix bug 1265151 - Missing translation of some strings

Added for string "Open in "

https://github.com/mozilla/kuma/commit/3d9998580b21b0751f0249a875d1d1491a926243
Fix bug 1265151 - added gettext in places of call

Added gettext in places of call because it doesn't work in other way

https://github.com/mozilla/kuma/commit/27fa9caf537471dd495e51f7c6273af105ed07cb
Fix bug 1265151 - strings in needs_review.html

https://github.com/mozilla/kuma/commit/ce9dcaa86e622adcf87f0c49bdd65b4333011967
Fix bug 1265151 - deleted gettext function from confirm

https://github.com/mozilla/kuma/commit/69a5290d407b7b24335b3eae46a54840b46b46ba
Fix bug 1265151 - fix gettext tp ngettext

https://github.com/mozilla/kuma/commit/1c750514cb5504739a0522e8ce40f7b7e02e8060
Fix bug 1265151

https://github.com/mozilla/kuma/commit/f0edccb23e662a99b879ac07aeab33d12d81231a
Fix bug 1265151 - typo

https://github.com/mozilla/kuma/commit/54ef9e73664c2c338ce6d059c943def2616f62b9
Fix bug 1265151 - ngettext to interpolate(gettext())

https://github.com/mozilla/kuma/commit/beadfb82826ef02697a1a6ad10e5eb7abcea827c
Fix bug 1265151

https://github.com/mozilla/kuma/commit/76cc7d80c8e8c9cf912646bd7ee5da089ea34dc6
Fix bug 1265151

https://github.com/mozilla/kuma/commit/3e42c05565ce9a7187b4884ee0e39a393800731a
Merge pull request #3878 from bychek-ru/Bug-1265151

Fix bug 1265151 - Missing translation of some strings

Comment 5

[Victor Bychek]

Reopened. See https://github.com/mozilla/kuma/pull/3880

Comment 6

[MDN Team (:mdn-dev)]

Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/3b1527cd1e1a04d692cce1d7410e34ed12a07ebb
Merge PR #3881

fix bug 1265151 - fix interpolate

Comment 7

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/2aea5d0d1c4f5ac9f7ceff9260a99ae37623671c
bug 1265151 - Add space back to sample buttons

While marking the text "Open in Codepen" for translation, the space
between the text and the icon was lost. It doesn't really belong in the
translated string, adding it as a literal string to the button.

https://github.com/mozilla/kuma/commit/1edcde0c8072024b0a38acdc511be323afed9574
Merge pull request #3882 from mozilla/fix_sample_buttons_1265151

bug 1265151 - Add space back to sample buttons