127072 - chromelist.txt has wrong separator on Windows

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Gervase Markham [:gerv]]

This is what comes of not having a Windows build system to test these changes on :-(

canonpath uses the platform-specific separator, so when I canonpath($cvsfile),
it switches the separators and makes Patch Maker unable to recognise it because
you get a path like:

en-US\locale\en-US\navigator\viewSource.dtd
(xpfe/browser/resources\locale\en-US\viewSource.dtd) 

Thanks to jonasj for noticing this.

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This should fix it, I hope.

Gerv

Comment 2

[Jonas Jørgensen]

Uhm, when will the fix be checked in?

Comment 3

[Gervase Markham [:gerv]]

When cls reviews it :-)

Gerv

Comment 4

[hacker formerly known as [e-mail]]

Comment on attachment 70761 [details] [diff] [review]
Patch v.1

r=cls
Still needs drivers approval.

Comment 5

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.9

Comment 6

[hacker formerly known as [e-mail]]

Patch checked in.