127269 - unneeded null checks in attribute mapping / rule mapping functions

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There are lots of unneeded null checks in attribute mapping functions (and
struct mapping functions?), dating back to when hyatt was rewriting things and
they were only partly written.  We should remove these (and make sure the caller
null checks the allocations before continuing).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Should do this at the same time as bug 107100.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

In particular, I think all the null checks should be replaced by SID checks (if
the SID checks aren't already there).  There's no need for null checks since
there's stack allocation, and SID checks mean we do less work.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch (diff -u)

This contains the fix for this bug (which might let us move towards a
blob-allocation system for the rule data structs), plus a little cleanup in
nsHTMLTableCellElement (which includes an ordering fix for
WalkContentStyleRules -- more specific comes first, although the current code
doesn't have any conflicts), plus the patch for bug 214077, which I didn't want
to bother separating.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch (diff -uw, for review)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 129489 [details] [diff] [review]
patch (diff -uw, for review)

r+sr=bzbarsky

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-09-10 18:34 -0700.