12808 - [BLOCKER] [PP] Clicking in gfx text field crashes

Status: VERIFIED WORKSFORME

(Core :: DOM: Editor, defect, P2)

Description

[Akkana Peck]

With gfx text widgets on ( user_pref("nglayout.compatibility.mode", 1); ),
whenever I click in any text field, I get an immediate crash, in

#0  0x40e21f08 in nsBlockFrame::HandleEvent (this=0x8684680,
    aPresContext=@0x8653a50, aEvent=0xbffff3cc, aEventStatus=@0xbffff340)
    at nsBlockFrame.cpp:5493

This is:
5493          returnFrame->GetOffsetFromView(offsetPoint, &view);

returnFrame and view seem to be valid pointers.  offsetPoint is {x = 141021720,
y = 1088506184} -- are those numbers unusually high?

Comment 1

[Chris McAfee]

gfx text widgets is "nglayout.compatibility.mode", 2
There's a pref UI for this in apprunner now, in addition
to the menu item that viewer has.

raising priority, this is a big gfx widget problem.

Comment 2

[buster]

I've been running with gfx text controls all day today with code from 8:30am
this morning, no crashes clicking on them.  Looks like it's linux only.
offsetPoint is in twips, but the numbers are ridiculous.  I would guess an
uninitialized variable?  Akkana, could you dig a little deeper into this?  Maybe
get Mike involved, I think it's his code.

Comment 3

[buster]

hmmm...I think the value of offsetPoint is irrelevant, it's an out param that
should get filled during the call to GetOffsetFromView.  The second param is an
out param as well.  I'd check out nsFrame::GetOffsetFromView.  It doesn't seem
that any of the other frame classes override this method.

Comment 4

[Akkana Peck]

Mike and I looked at it, and he's comparing on Windows now to see what the
values should be.  Reassigning (but he and I will work on finding a solution).

Comment 5

[Chris McAfee]

http://bugzilla.mozilla.org/show_bug.cgi?id=12899
says that this crashes Win32.

Comment 6

[Kevin McCluskey (gone)]

*** Bug 12899 has been marked as a duplicate of this bug. ***

Comment 7

[Chris McAfee]

This is workingforme, marking so.
Reopen if this is still a problem.

Comment 8

[rods (gone)]

I works today, but no cursor shows up.

Comment 9

[Chris McAfee]

worksforme.

simon's got another bug on the cursor problem.

Comment 10

[sujay]

verified in 9/8 build.