128335 - GetFactory in static build does linear search with string compares

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Simon Fraser [no longer active]]

In the static build, which uses nsStaticComponentLoader, doing a create instance 
by contract ID calls GetInfoFor(), which uses linear search through the 
registered modules doing a string compare on each. This will be slow!

Comment 1

[Doug Turner (:dougt)]

This is waterson's baby.

Comment 2

[Brendan Eich [:brendan]]

waterson's away till April -- if this needs attention sooner, pls. reassign.

/be

Comment 3

[Brendan Eich [:brendan]]

The static build rules, but this is a stain on its cold-start perf. 
Pre-approving for mozilla1.0.

/be

Comment 4

[Chris Waterson]

shaver says he'll fix it.

Comment 5

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Attachment: Use a dhash, mk 1.

Seems to work for me, but it's late, so I'll look again in the A.M.

Comment 6

[Chris Waterson]

Comment on attachment 80344 [details] [diff] [review]
Use a dhash, mk 1.

sr=waterson

Comment 7

[Doug Turner (:dougt)]

Comment on attachment 80344 [details] [diff] [review]
Use a dhash, mk 1.

nit

+    if (!mInfoHash.ops)	 // creation failed in init, why are we here?
+	 return NS_ERROR_NOT_INITIALIZED;

wanna add an assertion?

r=dougt

Comment 8

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Landed on the trunk.  dougt: I added an NS_WARNING there, thanks for the idea.