Closed
Bug 129539
Opened 22 years ago
Closed 22 years ago
unescaping regression from fix for bug 124042
Categories
(MailNews Core :: Backend, defect, P1)
MailNews Core
Backend
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0
People
(Reporter: darin.moz, Assigned: darin.moz)
References
Details
Attachments
(1 file)
953 bytes,
patch
|
sspitzer
:
review+
mscott
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
nsMsgMailNewsUrl::GetServer() calls nsIURI::GetUsername() expecting an unescaped username string, but GetUsername() now returns the escaped string since it cannot guarantee the charset of the unescaped string. I unfortunately missed this change when generating the patch for bug 124042 :-(
Assignee | ||
Comment 1•22 years ago
|
||
-> critical since this probably causes problems for i18n users.
Severity: normal → critical
Status: NEW → ASSIGNED
Keywords: nsbeta1
Priority: -- → P1
Target Milestone: --- → mozilla1.0
Assignee | ||
Comment 2•22 years ago
|
||
simple patch
Assignee | ||
Comment 3•22 years ago
|
||
scott, seth: can i get some r/sr= lovin from you guys?
Comment 4•22 years ago
|
||
Comment on attachment 73020 [details] [diff] [review] v1 patch sr=mscott
Attachment #73020 -
Flags: superreview+
Comment 5•22 years ago
|
||
Comment on attachment 73020 [details] [diff] [review] v1 patch r=sspitzer but heads up, I think all this code ties in to allowing "@" in the username. have you pop / imap tested accounts like that?
Attachment #73020 -
Flags: review+
Comment 6•22 years ago
|
||
Comment on attachment 73020 [details] [diff] [review] v1 patch a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #73020 -
Flags: approval+
Assignee | ||
Comment 7•22 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 8•22 years ago
|
||
*** Bug 129457 has been marked as a duplicate of this bug. ***
Comment 10•22 years ago
|
||
Darin, could you answer Esther's question? Thanks.
Assignee | ||
Comment 11•22 years ago
|
||
i'll only noticed this problem while reading through the code. i'm not sure exactly how this bug might have manifested itself... there is of course the duplicate bug 129457... you might try verifying that that bug is fixed. that said, this bug was very cut-and-dry. i simply forgot an obvious step.
Comment 12•22 years ago
|
||
verified based on the dup bug comments 10 & 16 that verify it was fixed.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•