129582 - Current MRE installation needs to be registered with nsDirectoryService

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Doug Turner (:dougt)]

see summary.

Comment 1

[Chak Nanga]

Hi Doug : Could you please explain this in a bit more detail...thanks

Comment 2

[Doug Turner (:dougt)]

sure.

When an MRE application starts up it, it is going to have to figure out which
MRE is will be using.  How this decision is made is outside of the scope of this
bug.  When the directory is know, it must be registered with the directory
service provider.  

At the minimum, we need to add a well known key to the directory service
provider so that XPCOM and other client can find this directory.  We need to
ensure that the embedding code does set this correctly when the MRE is found.

I hope this makes sense.

Comment 3

[Chak Nanga]

Changes to MfcEmbed to support registration of it's MRE dir location. Patch
attached.

Comment 4

[Chak Nanga]

Attachment: Really attaching the patch this time :-)

Comment 5

[Judson Valeski]

hardcoding paths here seems like the wrong direction?

Comment 6

[Chak Nanga]

The hardcoded paths are temporary..

Once we all agree and Syd provides me with the actual registry location of the
MRE installation then i'll take care of reading it from the registry and using
it approproately.

Comment 7

[Doug Turner (:dougt)]

pushing milestone out based on requirement feedback from Chak and Jud.

Comment 8

[Chak Nanga]

Comment on attachment 74337 [details] [diff] [review]
Really attaching the patch this time :-)

Obsoleting this patch. Updated patch forthcoming

Comment 9

[Chak Nanga]

Attachment: Updated patch to reflect current state of things...

This patch does the following:

Enables MfcEmbed to be run in an MRE based env - if it finds an MRE with which
it's compatible with. 
If it does not find an MRE installation i.e. if the registry does not have the
MRE related keys in it, then, MfcEmbed works like it always did(in a non-MRE
env)

By using this patch we preserve backward compatibility (i.e. be able to run in
a non-MRE env) while at the same time showing embeddors on how to use an MRE
when one becomes available.

Comment 10

[Doug Turner (:dougt)]

Comment on attachment 85802 [details] [diff] [review]
Updated patch to reflect current state of things...

::GetCurrentDirectory returns a string in the fs charset, you will want to use
NS_NewNativeLocalFile().  Same is true in GetMreDirectory.

why are you using nsCRT here?  Just use strdup/free directly.

didn't you have some xpcom changes?

Comment 11

[Chak Nanga]

Attachment: Patch which addresses dougt's comments above.

Comment 12

[Chak Nanga]

Cc:ing Adam for r=

Comment 13

[Chak Nanga]

Attachment: Uses NS_InitEmbedding() instead of NS_InitEmbedding2()

Going back to using NS_InitEmbedding() instead of NS_InitEmbedding2()

Comment 14

[Adam Lock]

Comment on attachment 86499 [details] [diff] [review]
Uses NS_InitEmbedding() instead of NS_InitEmbedding2()

You could use CRegKey instead of the native registry calls, but otherwise
r=adamlock.

So if mfcEmbed is not in the MRE directory, how does it resolve its
dependencies to xpcom.dll and other Moz files that it is dynamically linked to?

Comment 15

[Chak Nanga]

>So if mfcEmbed is not in the MRE directory, how does it resolve its
>dependencies to xpcom.dll and other Moz files that it is dynamically linked to? 

Can be done a couple of ways:

1. Via a batch file (here's a copy of my test batch file) :
E:\mreapp1>cat runapp.bat
@echo OFF
set PATH=%PATH%;E:\MRE1.0;E:\MRE1.0\components
mfcembed.exe -console

2. You can use the "Application Specific Paths" feature under Windows as
desribed below:

To use application specific paths:

1. Create a subkey with your application name as the keyname under the key shown
above

Ex: HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths\MyApp.exe

2. Set the (Default) value to the full path of your executable file

Ex: C:\Program Files\EmbedApp\MyApp.exe

3. Add a subkey named "Path" and set it's string value to the full path of the
MRE version your application is compatible with:

Ex : C:\MRE1.0 


The application installer can create the batch file or set the AppPath
appropriately.

Comment 16

[rpotts (gone)]

Comment on attachment 86499 [details] [diff] [review]
Uses NS_InitEmbedding() instead of NS_InitEmbedding2()

sr=[e-mail]

Comment 17

[Chak Nanga]

Landed patch on the trunk