1307889 - Support server log call messages

Status: RESOLVED WORKSFORME

(DevTools :: Console, enhancement)

Description

[Lin Clark [:linclark]]

Originally posted by:linclark

see https://github.com/devtools-html/gecko-dev/issues/199

Parent issue: #140 

Where it is received: https://dxr.mozilla.org/mozilla-central/source/devtools/client/webconsole/webconsole.js#3386

Where it comes from: https://dxr.mozilla.org/mozilla-central/source/devtools/server/actors/webconsole.js#1640

Current test:
  - browser_console_server_logging.js

Comment 1

[Brian Grinstead [:bgrins]]

Server logs are off by default in the old console, unblocking the enabling bug on this (not saying we won't fix it, but it's not at the same prioritization level as other things for riding to dev edition)

Comment 2

[Brian Grinstead [:bgrins]]

We should consider implementing this as a web extension based on the chrome logger spec this feature is based off of: https://craig.is/writing/chrome-logger/techspecs, or even reaching out to the author to see about porting it over to firefox: https://github.com/ccampbell/chromelogger/.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Brian Grinstead [:bgrins] from comment #2)
> We should consider implementing this as a web extension based on the chrome
> logger spec this feature is based off of:
> https://craig.is/writing/chrome-logger/techspecs, or even reaching out to
> the author to see about porting it over to firefox:
> https://github.com/ccampbell/chromelogger/.
Yes, I am also voting for making the Chrome logger extension to work in Firefox (based on standard Web Extension API) and reach the existing community around this extension.

Honza

Comment 4

[Patrick Brosset <:pbro>]

With Firebug going away in favor of DevTools, this is becoming a more pressing issue I think. There are a lot of shops out there who's business depend on PHP and Firebug's capability to display server-side logs.

Making chromelogger a cross-browser web extension would be awesome! We should reach out to the author via an issue on the github repo. Brian: will you do that or want me to?

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I also put the Chrome Logger extension into the list of DevTools extensions to analyze API requirements.
https://docs.google.com/document/d/1uvnO8hNLQuA50H0I0e4oTzFi_DvhbSvxr6nKj7k341s/edit#

Honza

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to Patrick Brosset <:pbro> from comment #4)
> With Firebug going away in favor of DevTools, this is becoming a more
> pressing issue I think. There are a lot of shops out there who's business
> depend on PHP and Firebug's capability to display server-side logs.
> 
> Making chromelogger a cross-browser web extension would be awesome! We
> should reach out to the author via an issue on the github repo. Brian: will
> you do that or want me to?

Please do - I'll be unavailable for a couple of weeks.

Comment 8

[Lorenzo Stanco]

I'm using Firefox 53 and I can see server console messages. Today I tried nigthly 55 today, but the new different filtering options does not include "Server" anymore, and my server console messages are missing. Is this what you are discussing here, or it's a different issue/bug I should report? If yes, why it has been removed?

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I am using this bug to track progress on fixing the existing Chrome Logger extension and making it compatible with Firefox Web Extensions API

Here is first PR on github:
https://github.com/ccampbell/chromelogger/pull/73

Honza

Comment 12

[Brian Grinstead [:bgrins]]

I see that the PR got merged - what are the next steps to get this resolved?

Comment 13

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Brian Grinstead [:bgrins] from comment #12)
> I see that the PR got merged - what are the next steps to get this resolved?
Craig is now looking at how to get the extension on AMO.

Honza

Comment 15

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Chrome Logger by Spencer T⋆ Obremski extension [1] is now available in our DevTools collection [2]
This extension is based on ChromeLogger from Craig Campbell [3] (originally introduced for Chrome)

[1] https://addons.mozilla.org/en-US/firefox/addon/chromelogger/
[2] https://addons.mozilla.org/en-US/firefox/collections/mozilla/webdeveloper/
[3] https://craig.is/writing/chrome-logger/

So, I am closing this bug.

Honza

Comment 16

[C. Martin]

Please don't close it just yet, because the extension doesn't work for me, at least not with ChromePhp. Judging from the comments on the extension's page I'm not the only one.

It throws an error in the console:
Type Error
columnNumber: 3
fileName: "moz-extension://2fc6a7d6-f1d5-44d8-9fa2-954e4b7ced8b/log.js"
lineNumber: 17
message: "window.console[method] is undefined"
stack: "forEachChromeLoggerDataRow@moz-extension://2fc6a7d6-f1d5-44d8-9fa2-954e4b7ced8b/log.js:17:3\n@moz-extension://2fc6a7d6-f1d5-44d8-9fa2-954e4b7ced8b/log.js:31:2\n"
log.js:19:3

I'm at a loss...?

Comment 17

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to C. Martin from comment #16)
> Please don't close it just yet, because the extension doesn't work for me,
> at least not with ChromePhp. Judging from the comments on the extension's
> page I'm not the only one.
This bug, was about supporting ChromeLogger and its protocol (since the feature
was previously built-in DevTools). 

The extension works for me on this page:
https://craig.is/writing/chrome-logger
I am seeing `Hello World` message + an array logged into the Console panel.

This bug isn't covering any specific features of that extension and you
need to request the author to support other protocols and/or fix bugs.

Honza

Comment 18

[C. Martin]

Thanks for the quick reply. The issue seems to be with ChromePhp.
In face ChromePhp::warn(), ChromePhp::error(), ChromePhp::info() all work, just ChromePhp::log() doesn't.