1339314 - stylo: update glue to set clip-path as a mozilla::StyleShapeSource

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

Bug 1336905 does some refactoring of how computed clip-path values are stored.  Manish, if you have time, could you handle the stylo glue side of this?

Comment 1

[Manish Goregaokar [:manishearth]]

Attachment: Bug 1339314: stylo: update bindings for clip-path changes from bug 1336905;

Review commit: https://reviewboard.mozilla.org/r/112462/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112462/

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8837300 [details]
Bug 1339314: stylo: update bindings for clip-path changes from bug 1336905;

https://reviewboard.mozilla.org/r/112462/#review113952

Comment 3

[u459114]

Hi Mansih,
Could you click autoland button here at [1] before you land patch here?

[1] https://reviewboard.mozilla.org/r/109996/

Comment 4

[Cameron McCormack (:heycam)]

(Also let's hold off on landing until the Servo autosyncing service is running again, or the jobs have been hidden on treeherder.  Otherwise the Servo-side change won't make it to autoland and we'll still break the stylo jobs.)

Comment 5

[Manish Goregaokar [:manishearth]]

Okay, I'll wait. ni me again when you need this.

Comment 6

[u459114]

Patches in bug 1336905 had been rebase on the latest central.
Hi heycam,  is servo autosyncing service running now?

Comment 7

[Manish Goregaokar [:manishearth]]

Yep. I'll land that side.

Comment 8

[Manish Goregaokar [:manishearth]]

Comment on attachment 8837300 [details]
Bug 1339314: stylo: update bindings for clip-path changes from bug 1336905;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112462/diff/1-2/

Comment 9

[Manish Goregaokar [:manishearth]]

this was fixed in https://github.com/servo/servo/pull/15675