134227 - Update Mac Installer for Mozilla 1.0 release

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P1)

Description

[lpham]

Need two patches. 
One is for the trunk, and one is for MOZILLA_1_0_0_BRANCH
This bug must do after releasing Mozilla 1.0 RC1

Comment 1

[Asa Dotzler [:asa]]

must have. mozilla1.0+

Comment 2

[J.J. Enser]

don't understand the summary. Loan, what's this update about?

Comment 3

[lpham]

mozilla/xpinstall/wizard/mac/rsrc/Mozilla.rsrc and
mozilla/xpinstall/wizard/mac/macbuild/config.ini_tmpl need to be updated for
Mozilla 1.0 release.  They are in version_string_checklist.html section 2.1.3
(I'm not sure we need to do anything with config.ini_tmpl, but the checklist
still lists this file.  If we don't need to modify config.ini_tmpl, please
remove it from  version_string_checklist.html).

Comment 4

[kysmith0 (gone)]

regarding the config.ini_tmpl file, there is an effort currently underway to
determine what we are supposed to be changing each time we update a
version...specifically we need to know "how does the Version parameter get used"
so we can determine the values to supply to this parameter which is contained in
the file. SO at this point, we don't really know what to put in for the Version
field...we just think that we should be changing it. 

Once the research effort is done (which I will log a big for and assign to JJ
since he is driving the research effort) we will know what to do with this
Version parameter in the config.ini_tmpl file and we can update the
version_string_checklist document with this info.

I'd like to leave the file listed on the version_string_checklist document even
though we don't know what to do with it yet. Loan is this ok with you? 

Comment 5

[lpham]

We need to land this bug for Mozilla 1.0 RC1. It is ok to land on
MOZILLA_1_0_0_BRANCH and the trunk now.  Need r= and sr= for your patch and
check them in when the tree is open. a=[e-mail]

Comment 6

[J.J. Enser]

Attachment: Patch to config.ini_tmpl for 1.0.0

Found out what to do with config.ini_tmpl. The 'Version=' value needs in fact
to be updated for every release. Is there another bug/place to provide detailed
explanation or should I just do it here?

As to Mozilla.rsrc, I cannot submit a patch since it's a binary file. The
"patch" is to change 'vers' ID=2 resource as follows:
. version bits: 0.9.9 -> 1.0.0
. short version string: "0.9.9+" to "1.0.0"
. long version string: "Mozilla 0.9.9+ Installer" to "Mozilla 1.0.0 Installer"

awaiting r= and sr= to check in both files on the trunk and the branch

Comment 7

[Jon Granrose]

sr=granrose, pending r=leaf and assuming trunk changes will have trunk values
(1.0.0+ and 1.0.0.d [or something like that])

I saw sgehani's comments in the 097 installer bug about the values for this
file.  I'd add them to the version checklist so we have them documented for the
next release.

Comment 8

[J.J. Enser]

mozilla.rsrc and config.ini_tmpl checked in on the 1.0 branch

Comment 9

[J.J. Enser]

also landed equivalent patches for the trunk:
. mozilla.rsrc -> 1.0.0+
. config.ini_tmpl -> 1.0.0 (no plus in that string)

Comment 10

[Tracy Walker [:tracy]]

verified checked in