Closed
Bug 1376300
Opened 7 years ago
Closed 7 years ago
Missing getter methods in JDAPFilter classes
Categories
(Directory :: LDAP Java SDK, defect)
Directory
LDAP Java SDK
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: edewata, Assigned: edewata)
Details
Attachments
(1 file)
12.96 KB,
patch
|
jmagne
:
review+
richm
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0 Build ID: 20170608105825 Steps to reproduce: The LDAP Java SDK provides a mechanism to parse a string LDAP filter into a JDAPFilter object tree: JDAPFilter filter = JDAPFilter.getFilter(strFilter); However, some of the JDAPFilter classes do not provide methods to access the fields in the objects, limiting its usability. For example: * JDAPFilterSet does not provide getSet() method to access the filter set joined by the AND/OR operators. * JDAPFilterNot does not provide getFilter() to access the filter negated by NOT operator. * JDAPFilterSubString does not provide getInitial(), getAny(), getFinal() to access parts of the substring filter.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8914533 -
Flags: review?(cfu)
Assignee | ||
Updated•7 years ago
|
Attachment #8914533 -
Flags: review?(cfu) → review?(jmagne)
Attachment #8914533 -
Flags: review?(jmagne) → review+
Comment 2•7 years ago
|
||
Comment on attachment 8914533 [details] [diff] [review] bug-1376300.patch pushed https://hg.mozilla.org/projects/ldap-sdks/rev/460afcc31771176e7a40f452be14ce5869831ddd If this looks correct, please close.
Attachment #8914533 -
Flags: review+
Assignee | ||
Comment 3•7 years ago
|
||
That looks correct. Thanks, Rich! Could someone close this ticket? I don't think I have the permission to do that properly. Thanks!
Updated•7 years ago
|
Assignee: nobody → edewata
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•7 years ago
|
||
Fedora ticket: https://bugzilla.redhat.com/show_bug.cgi?id=1465102
You need to log in
before you can comment on or make changes to this bug.
Description
•