Closed Bug 1388941 Opened 7 years ago Closed 7 years ago

stylo: min font size doesn't work within ruby

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: manishearth, Assigned: manishearth)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

./layout/reftests/css-ruby/min-font-size-1.html fails because of this.

Opening the testcase with font.minimum-size.ja = 16 will show that the main text is clamped to 16px, but the ruby atop it is extremely tiny.

<rt> uses -moz-min-font-size-ratio so we probably mess up there.
First commit is totally unrelated but it's a minor failure list fix so *shrug*
Comment on attachment 8895632 [details]
Bug 1388941 - Correctly scale -moz-min-font-size-ratio ;

https://reviewboard.mozilla.org/r/166876/#review172054
Attachment #8895632 - Flags: review?(cam) → review+
Pushed by manishearth@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cffa7014eb0c
Remove unnecessary fails(stylo) annotation from fuzzy test; r=heycam
https://hg.mozilla.org/integration/autoland/rev/7446c325724d
Correctly scale -moz-min-font-size-ratio ; r=heycam
https://hg.mozilla.org/mozilla-central/rev/cffa7014eb0c
https://hg.mozilla.org/mozilla-central/rev/7446c325724d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: