139188 - Form Manager - Manage Sites window not resizeable

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect, P4)

Description

[Kai Stukenbrock]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0rc1)
Gecko/20020417
BuildID:    2002041711

When in Preferences choosing the Form Manager and then clicking on "Managing
Sites", the resulting window cannot be resized.

Reproducible: Always
Steps to Reproduce:
Open Preferences - Privacy and Security - Forms - Manage Sites

Actual Results:  Window not resizeable

Expected Results:  Should be resizeable

Comment 1

[Rainer Bielefeld]

Confirm with Mozilla/5.0 (Windows; U; Win98; de-AT; rv:1.0rc1) Gecko/20020417
All other similar windows in "Preferenzes" are resizable, this one is not.

Comment 2

[Vadim Berezniker]

Agreed. It should be resizable.
(I can force the dialog to resize and it looks OK)

Comment 3

[Rainer Bielefeld]

Now I really have a german Language RC1
Mozilla/5.0 (Windows; U; Win98; de-AT; rv:1.0rc1) Gecko/20020417
(de-AT in  #1 is nonsense, there english language + contents-package was installed)

And now as fas as I tested _no_ window in "edit/preferences" can be resized.
It is not a real problem, because all Windows are big enough, but I think, that
it is not such a good Idea to have such different reactions with different
language-packs.

Comment 4

[Stephen P. Morse]

Based on comment #3, this is a general problem affecting all preference panels 
and not just form manager.   Therefore reassigning to preferences component.

Changing title from

   Form Manager - Manage Sites window not resizeable

to

   Preference panels not resizeable

Comment 5

[timeless]

morse: you've been mislead
1. the things described in comment 3 are panels, not windows
2. ben has declared that the preferences dialog will not be resizable
3. the window this bug was reported against is a window that is spawned from 
the preferences dialog and is not otherwise related to the preferences dialog

Comment 6

[Shoshannah Forbes]

On OSX, the problem is worse, since the "manage sites" db opens too small (at
least in the classic theme)

Comment 7

[Shoshannah Forbes]

Attachment: A screen shot of the db on OSX

Comment 8

[R.K.Aa.]

*** Bug 157041 has been marked as a duplicate of this bug. ***

Comment 9

[HJ]

Steve, can you please replace this line: 

http://lxr.mozilla.org/seamonkey/source/extensions/wallet/resources/content/walletOverlay.js#360
          window.openDialog("chrome://communicator/content/wallet/SignonViewer.xul",
                   "_blank","chrome,resizable=no","W");
                                             ^^^

so that the Form Manager can be resized, like all other managers
(Cookies/Images/Bookmarks/Passwords/Download).

Thanks.

Comment 10

[Stephen P. Morse]

The change needs to be made in the following place as well:

   extensions/wallet/resources/content/pref-wallet.xul#47

HJ, I'll let you go for it.  r=morse, providing you make the change in both
places.  Now get a superreview and check it in.

Comment 11

[Heikki Toivonen (remove -bugzilla when emailing directly)]

This one also has a trivial fix, and it is actually shown and r=morse.

Reassigning to new owner for sr and checkin.

Comment 12

[Stefan Borggraefe]

Taking.

Comment 13

[Stefan Borggraefe]

Attachment: Fix

There were actually two places where this needed to be changed. The first for
the menu item and the second for the buttons in Preferences.

Comment 14

[Stefan Borggraefe]

Comment on attachment 131953 [details] [diff] [review]
Fix

Will r=+ be enough for this simple patch?

Comment 15

[Daniel Veditz [:dveditz]]

Comment on attachment 131953 [details] [diff] [review]
Fix

r+sr=dveditz

Comment 16

[Stefan Borggraefe]

Checked in by bzbarsky. Thanks for that and die review!

Marking FIXED.

Comment 17

[Hasham]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13) Gecko/20080313 SeaMonkey/1.1.9

Firefox no longer has a Forms Manger UI so I used SeaMonkey to test this. Verified.