140757 - RFE: [PATCH] add text between the dropdowns at Search History window

Status: RESOLVED INVALID

(Core :: Internationalization, defect)

Description

[Tsahi Asher]

in the Search History window (History viewer: Tools|Search History), when
localizing to Hebrew, i need extra text between the two drop down menues. a
moment of Hebrew: in hebrew, if i wanted to look for a URL who's Name
Contains "foo", i would write something like:

Find visited documents that the [name] of them [contains] "foo"

they way things are now, i don't have a place to put the 'of them' part, and so
i'm forced to add it to each item in the second dropdown.

to fix this, you only need an extra entity at
http://lxr.mozilla.org/seamonkey/source/xpfe/components/history/resources/locale/en-US/findHistory.dtd
to contain this text, or remain empty in languages that don't require it.

Comment 1

[Tsahi Asher]

Attachment: fixed findHistory.xul

Comment 2

[Tsahi Asher]

Attachment: corresponding findHistory.dtd

i know nothing in XUL/XML, so this was pure guesswork. but it works ok. feel
free to make a better patch.

Comment 3

[Roy Yokoyama]

Assign to tao to get recommendation

Comment 4

[Keyser Sose]

Marking NEW for patch loving.

Comment 5

[Tsahi Asher]

at least for hebrew, i could find a phrasing that overcomes this difficulty,
which will be available in the language pack for moz1.3 (in about 2 weeks). but
i don't know if there aren't any other languages with similar problems.

Comment 6

[tao]

Hi, Bob: please reassign these i18n/l10n/l12y bugs accordingly. thx!

Comment 7

[Tsahi Asher]

there is another problem: in hebrew, "title" is female and "location" is male.
this poses a problem with the search operators. see the description of bug
159527 for details. so in addition to the "of them" problem that might have a
solution, i need two sets of search operators, one in male form and one in
female form, to match the corresponding search term.

Comment 8

[Robert Kaiser]

SeaMonkey 2 doesn't have the "Search History" window any more, so this is INVA now. Tsahi, thanks for pointing this out.