142122 - [FIXr]line-through is drawn as underline

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Koike Kazuhiko]

"text-decoration: line-through" is drawn as underline.

Testcase:
http://bugzilla.mozilla.org/attachment.cgi?id=71636

Comment 1

[Koike Kazuhiko]

Attachment: Screenshot

Comment 2

[Boris Zbarsky [:bzbarsky]]

This worksforme, linux trunk build 2002-05-01-21

Comment 3

[Koike Kazuhiko]

This bug can be reprodoced with several Japanese fonts.

kaname-fixed: all lines are drawn as underline

shinonome-fixed: 9,10,15-32px are drawn as underline

alias-fixed: 16-18px are drawn as underline
jis-fixed: 16-18px are drawn as underline
misc-fixed: 16-18px are drawn as underline

aliastt-gothic: no problem
wadalab-gothic: no problem

Comment 4

[Hideo Saito]

Attachment: patch in case the font height is 0

When the property of a font property atom XA_X_HEIGHT is acquired, 
the value 0 is returned from X11 library XGetFontProperty() function.
In this case, line-through is drawn as underline.

Comment 5

[Laura Krietemeyer]

Changing QA Contact

Comment 6

[Håkan Waara]

Rbs, can you have a look at Hideo's patch, or delegate the review to someone else?

Comment 7

[Carine Held]

Reproduced in 1/03/03 Linux trunk.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 82426 [details] [diff] [review]
patch in case the font height is 0

Could this be approved for 1.4b?  This just sanity-checks the x-height that X
returns and treats it as unknown if 0 is returned...

Comment 9

[Boris Zbarsky [:bzbarsky]]

Taking to keep track of this.

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 82426 [details] [diff] [review]
patch in case the font height is 0

a=sspitzer

Comment 11

[Boris Zbarsky [:bzbarsky]]

Checked in (and I patched xlib the same way too).

Comment 12

[Roland Mainz]

Boris Zbarsky wrote:
> Checked in (and I patched xlib the same way too).
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Thanks! :)