Closed
Bug 142597
Opened 22 years ago
Closed 22 years ago
Dictionary names in spelling dialog are not localized (regression)
Categories
(Core :: Internationalization: Localization, defect, P3)
Tracking
()
VERIFIED
FIXED
mozilla1.0.1
People
(Reporter: m.wawoczny, Assigned: cmanske)
References
Details
(Keywords: intl, regression, Whiteboard: [adt3 RTM][VERIFIED_IN_TRUNK][FIXED_IN_BRANCH],custrtm-)
Attachments
(2 files, 1 obsolete file)
2.24 KB,
image/gif
|
Details | |
3.91 KB,
patch
|
andreww
:
review+
hewitt
:
superreview+
jesup
:
approval+
|
Details | Diff | Splinter Review |
Dictionary names in spelling dialog are not localized (regression), attaching screenshot and patch. Mozilla/5.0 (Windows; U; Windows NT 5.0; pl-PL; rv:1.0.0+) Gecko/20020504
Reporter | ||
Updated•22 years ago
|
Component: Editor: Core → Localization
Keywords: patch,
regression
Reporter | ||
Comment 1•22 years ago
|
||
Reporter | ||
Comment 2•22 years ago
|
||
*** Bug 143057 has been marked as a duplicate of this bug. ***
Can I get someone familiar in the ways of UI localization and stringbundles to review this? cmanske? brade? yokoyama? I can sr afterwards.
Assignee: kin → cmanske
Priority: -- → P3
Target Milestone: --- → mozilla1.0
Reporter | ||
Comment 6•22 years ago
|
||
Check this bug: http://bugzilla.mozilla.org/show_bug.cgi?id=56680 - "use a xul <stringbundle/> instead of including the strres.js code"
Assignee | ||
Comment 7•22 years ago
|
||
Building NS tree now and will test/review asap.
Assignee | ||
Comment 8•22 years ago
|
||
Updated patch; seems to need "getString" when using XUL stringbundle element.
Attachment #82509 -
Attachment is obsolete: true
Assignee | ||
Updated•22 years ago
|
Whiteboard: [RTM] → [RTM][FIX IN HAND][need r=,sr=]
Updated•22 years ago
|
Comment on attachment 83087 [details] [diff] [review] patch v2 r=andreww not sure about the getString issue. You might want to get someone like Hewitt or Blake for super review and to reality-check that. I see both instances in the existing code - like in: http://lxr.mozilla.org/seamonkey/source/extensions/wallet/editor/WalletEditor.j s#684
Attachment #83087 -
Flags: review+
Assignee | ||
Updated•22 years ago
|
Whiteboard: [RTM][FIX IN HAND][need r=,sr=] → [RTM][FIX IN HAND][need sr=]
Comment 10•22 years ago
|
||
Comment on attachment 83087 [details] [diff] [review] patch v2 sr=hewitt
Attachment #83087 -
Flags: superreview+
Assignee | ||
Updated•22 years ago
|
Whiteboard: [RTM][FIX IN HAND][need sr=] → [RTM][FIX IN HAND]
Comment 11•22 years ago
|
||
cmanske- could you land into trunk asap and mark bug as fixed. IQA- please verify trunk after cmanske land into trunk. Thanks
Assignee | ||
Comment 12•22 years ago
|
||
checked into trunk
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Whiteboard: [RTM][FIX IN HAND] → [adt3 RTM][FIXED_IN_TRUNK]
Comment 13•22 years ago
|
||
can someone in IQA please verify this ? thanks
Comment 14•22 years ago
|
||
cc: yuying also...ylong, can you make sure someone in IQA verifies this one? thanks...
Comment 15•22 years ago
|
||
I saw this get fixed on 05-17 trunk build/WinME-JA - they are showing language names instead of language ID now. Mark as verified.
Status: RESOLVED → VERIFIED
Whiteboard: [adt3 RTM][FIXED_IN_TRUNK] → [adt3 RTM][VERIFIED_IN_TRUNK]
Comment 16•22 years ago
|
||
adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch, pending Drivers approval. After, checking in, please add the fixed1.0 keyword.
Comment 17•22 years ago
|
||
changing to adt1.0.1+ for checkin to the 1.0 branch for the Mozilla1.0.1 milestone. Please get drivers approval before checking in.
Updated•22 years ago
|
Keywords: mozilla1.0.1
Whiteboard: [adt3 RTM][VERIFIED_IN_TRUNK] [Needs a=] → [adt3 RTM][VERIFIED_IN_TRUNK] [Needs a=],custrtm
Assignee | ||
Updated•22 years ago
|
Target Milestone: mozilla1.0 → mozilla1.0.1
Comment 18•22 years ago
|
||
a=chofmann for 1.0.1
Comment 19•22 years ago
|
||
Comment on attachment 83087 [details] [diff] [review] patch v2 Marking chofmann's a=
Attachment #83087 -
Flags: approval+
Comment 20•22 years ago
|
||
please check into the 1.0.1 branch ASAP. once landed remove the mozilla1.0.1+ keyword and add the fixed1.0.1 keyword
Assignee | ||
Updated•22 years ago
|
Keywords: mozilla1.0.1+ → fixed1.0.1
Whiteboard: [adt3 RTM][VERIFIED_IN_TRUNK] [Needs a=],custrtm → [adt3 RTM][VERIFIED_IN_TRUNK][FIXED_IN_BRANCH],custrtm
Assignee | ||
Comment 21•22 years ago
|
||
oops! forgot to mention I just checked in fix to 1.0.1 branch
Comment 22•22 years ago
|
||
ylong, please verify on branch and add "verified1.0.1" keyword. thanks
Updated•22 years ago
|
Whiteboard: [adt3 RTM][VERIFIED_IN_TRUNK][FIXED_IN_BRANCH],custrtm → [adt3 RTM][VERIFIED_IN_TRUNK][FIXED_IN_BRANCH],custrtm-
Updated•22 years ago
|
Comment 23•22 years ago
|
||
Verified on 06-05 branch build on WinXP-SC.
Keywords: fixed1.0.1 → verified1.0.1
You need to log in
before you can comment on or make changes to this bug.
Description
•