Closed
Bug 143486
Opened 22 years ago
Closed 22 years ago
enter_bug.cgi: Using ?format=simple doesn't work
Categories
(Bugzilla :: Creating/Changing Bugs, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: burnus, Assigned: burnus)
Details
(Keywords: regression)
Attachments
(1 file)
618 bytes,
patch
|
gerv
:
review+
gerv
:
review+
|
Details | Diff | Splinter Review |
It is now possible to use more than one format for enter_bug.cgi (bug 138903). But here it doesn't work. I traced it down to my $format = ValidateOutputFormat($::FORM{'format'}, "create"); is called. This sets $scriptdir to "create". It works with "bug/create" Patch to come.
Assignee | ||
Comment 1•22 years ago
|
||
Assignee | ||
Updated•22 years ago
|
Target Milestone: --- → Bugzilla 2.16
Updated•22 years ago
|
Comment 2•22 years ago
|
||
Comment on attachment 83053 [details] [diff] [review] Patch enter_bug.cgi to make it work with format This looks like a side-effect of moving the template directory. good catch. But we don't need "create" in the list at all anymore. They are all in the bug/create directory. let's remove "create" from the list.
Attachment #83053 -
Flags: review-
Updated•22 years ago
|
Keywords: regression
Comment 4•22 years ago
|
||
> It is now possible to use more than one format for enter_bug.cgi
Well, actually it's not, because the "simple" (Bugzilla Helper replacement)
template sitting on my hard drive hasn't been checked in yet :-) I hope to have
it up for review this weekend.
Gerv
Assignee | ||
Comment 5•22 years ago
|
||
> But we don't need "create" in the list at all anymore. They are all in the > bug/create directory. let's remove "create" from the list. I'm not sure how I have to understead it. -my $format = ValidateOutputFormat($::FORM{'format'}, "create"); +my $format = ValidateOutputFormat($::FORM{'format'}, "create", "bug/create"); the second parameter is the $script the third parameter is the $subdir and in global.pl: $subdir = $script if !defined($subdir); I don't see another solution as done in attachment 83053 [details] [diff] [review]. > > It is now possible to use more than one format for enter_bug.cgi > Well, actually it's not. I ment my own create-simple.html.tmpl ;-)
Comment 6•22 years ago
|
||
OK, maybe I misunderstood the parameters on that code... Gerv?
Comment 7•22 years ago
|
||
Comment on attachment 83053 [details] [diff] [review] Patch enter_bug.cgi to make it work with format This is the right fix. At least, it makes my create-simple.html.tmpl work :-) Gerv
Attachment #83053 -
Flags: review-
Attachment #83053 -
Flags: review+
Comment 8•22 years ago
|
||
Fixed on trunk and branch. Checking in enter_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v <-- enter_bug.cgi new revision: 1.67; previous revision: 1.66 done Checking in enter_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v <-- enter_bug.cgi new revision: 1.66.2.1; previous revision: 1.66 done Gerv
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•