145702 - query.cgi doesn't always ConnectToDatabase() early enough

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Michael G. Katzmann]

If the query.cgi is accessed before an intial login has occured (on a web 
browser users computer) of a bugzilla installation (in 2.16RC1), a "Software 
error" is generated.

Software error:

Can't call method "prepare" on an undefined value at globals.pl line 270.

This problem goes away once a login has occured. (Then, it doesn't matter
then whether the user is logged in or out after that initial login)

Comment 1

[Bradley Baetz (:bbaetz)]

*cough* ConnectToDatabase not being called *cough*

See bug 139632. This is the identical problem.

I missed this in my auid I did in that bug. We have to ConnectToDatabse before
_anything_ else, including GetVersionTable().

Note that this only happens if its a user who doens't have any cookies who tries
to log in when we want to run our hourly versioncache/token table cleanup.

-> 2.16

Comment 2

[Matthew Tuck [:CodeMachine]]

Can we now please stop bandaging these symptoms and fix the real problem?

Comment 3

[Bradley Baetz (:bbaetz)]

*** Bug 146585 has been marked as a duplicate of this bug. ***

Comment 4

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This seems to be what's required, and it fixes the problem.

Gerv

Comment 5

[Bradley Baetz (:bbaetz)]

Comment on attachment 85032 [details] [diff] [review]
Patch v.1

grr - I thought I commented on this last night.

Anyway, you need to ConnectToDatabase before checking if the login is valid,
not afterwards.

Comment 6

[Bradley Baetz (:bbaetz)]

Attachment: v2

Comment 7

[Dave Miller [:justdave]]

Comment on attachment 85867 [details] [diff] [review]
v2

r= justdave

Comment 8

[J. Paul Reed [:preed]]

Comment on attachment 85867 [details] [diff] [review]
v2

Tested on a 2.16rc1 installation where I was observing this problem; worked
great!

r2=preed

Comment 9

[Bradley Baetz (:bbaetz)]

Checked in, 2.16 branch + trunk.

Comment 10

[Christian Reis]

This just bit me. Maybe the error message could be a bit nicer so we actually
know that it's just ConnectToDatabase() that's missing..