146091 - Sort order for votes is ascending instead of descending.

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect, P2)

Description

[Matthew Tuck [:CodeMachine]]

When you choose to sort on votes by clicking on the column heading on
buglist.cgi, it ends up sorting in ascending order rather than descending order
as you would expect.

I believe this is a regression, as it works on mozilla.org.

Comment 1

[Matthew Tuck [:CodeMachine]]

Myk did this, adding him.

There is a comment in the source about adding DESC to votes, but it isn't
actually done anymore.

Comment 2

[Matthew Tuck [:CodeMachine]]

Sorry I was mistaken there is code for it.  It's:

    # If we are sorting by votes, sort in descending order.
    if ($db_order =~ /bugs.votes\s+(asc|desc){0}/i) {
        $db_order =~ s/bugs.votes/bugs.votes desc/i;
    }

What does the {0} mean?  Wouldn't that make what occurs before get ignored, and
the regexp in effect be /bugs.votes\s+/ ?  Or is that something to prevent
greediness?

Even besides that this is possibly because asc no longer appears normally.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

This patch fixes the problem by not requiring whitespace between the field name
and the (optional) ascending/descending marker.

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 84650 [details] [diff] [review]
patch v1: fixes problem

2xr=gerv.

Gerv

Comment 5

[Gervase Markham [:gerv]]

Checked in on trunk and branch.

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.169.2.3; previous revision: 1.169.2.2
done

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.172; previous revision: 1.171
done

Gerv