Closed Bug 147272 Opened 22 years ago Closed 22 years ago

No background for Bugzilla pages.

Categories

(Bugzilla :: User Interface, defect)

Product:
Bugzilla
Component:
User Interface
Version:
2.15
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.16

People

(Reporter: CodeMachine, Assigned: bbaetz)

Details

(Keywords: polish, regression)

Attachments

(1 file)

patch
1.21 KB, patch
justdave
: review+
preed
: review+
Details | Diff | Splinter Review 
The current Bugzilla templates have no background set, which is a regression
from 2.14.  In particular the background used to be set to white.

This is not a problem in NGLayout browsers where the default is white, but the
default in N4 is grey.  This means this look and feel of Bugzilla has changed on
N4.

I suggest we set a default CSS block where style is not passed into the header
template, or even better, a default CSS rule that style adds to.
But ns4 won't handle the css, will it? Lets just change the default header
template to add a bgcolor attribute to <body>. Optionally, do so only if the
body attrs passed in don't have a bgcolor, but I don't think we set that
anywhere, do we?
We should do this for 2.16, since the fix is trivial, and its a regression
Keywords: polish, regression
Target Milestone: --- → Bugzilla 2.16
NS4 isn't dumb when it comes to simple CSS, there's a 99% chance it does it.

But using <BODY> attributes might be a better choice because they're always
overridden by CSS.
Taking - I have a patch
Assignee: myk → bbaetz
Keywords: patch, review
Attached patch patch — — Splinter Review 
OK, here we go.

This also fixes the problem I noticed in ns4 where the link for the banner
image also includes one unit of whitespace to the right, obviously because the
whitespace between the <img> and the </a> is considered to be part of the link,
and is thus shown with a blue underline.

Also, note that you need the ?: clustering operator, or you need to use match.
This is because .search will return what the thing matches (ie the ^), which
isn't actually a character, so it evaluates to false. This may be a TT bug, but
.search is deprecated anyway.
Whiteboard: want for 2.16rc2
Comment on attachment 85142 [details] [diff] [review]
patch

r= justdave
Attachment #85142 - Flags: review+
Comment on attachment 85142 [details] [diff] [review]
patch

Looks good. r2=preed
Attachment #85142 - Flags: review+
Checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
not checked in on 2.16 branch
Grr. Thanks!
Whiteboard: want for 2.16rc2
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: