Closed Bug 148767 Opened 22 years ago Closed 22 years ago

buglist.cgi outputs a warning if first query doesn't have a sort order

Categories

(Bugzilla :: Query/Bug List, defect)

Product:
Bugzilla
Component:
Query/Bug List
Version:
2.17
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.16

People

(Reporter: jouni, Assigned: jouni)

Details

(Keywords: regression)

Attachments

(1 file)

Patch
695 bytes, patch
myk
: review+
myk
: review+
Details | Diff | Splinter Review 
If the first query ever run by a user (no LASTORDER cookie) has a 'reuse' sort
order, buglist.cgi throws a pair of uninitialized warnings. Patch incoming.
Attached patch Patch — — Splinter Review 
Adds a pair of parenthesis.
Myk, this is your code. How about a quick review and checkin to branch & trunk?
Status: NEW → ASSIGNED
Keywords: patch, regression, review
Target Milestone: --- → Bugzilla 2.16
Comment on attachment 86039 [details] [diff] [review]
Patch

2xr=myk
Attachment #86039 - Flags: review+
Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.173; previous revision: 1.172
done

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.169.2.4; previous revision: 1.169.2.3
done
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: