150650 - Remove CTRL+SHIFT+I keybinding for inspecting page

Status: RESOLVED WONTFIX

(Other Applications :: DOM Inspector, defect)

Description

[David Majda]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.0.0) Gecko/20020530
BuildID:    2002053012

One would expect that shortcut to the DOM Inspector (Ctrl+Shift+I) will be
displayed next to it's menu item (in Tools|Web Development). But it isn't.

Reproducible: Always
Steps to Reproduce:
1. Open Tools|Web Development menu.

Comment 1

[timeless]

cool, since that was probably never approved, someone will have to remove the 
keybinding, thank you for reporting this feature, it will be removed unless 
someone from the keybinding world elects to save it.

Comment 2

[Tara]

When running instant messenger trillian (http://trillian.cc/) the shortcut is
disabled. Very annoying!

Comment 3

[Alex Vincent [:WeirdAl]]

There's a reason the shortcut isn't displayed quite that way.  Using the menu
option opens DOM Inspector with no document selected.  Using CTRL+SHIFT+i opens
DOM Inspector and tells it to reference the document in the window.

To properly resolve this bug, you'd really need to add a new menu option to the
Web Development menu labeled "Inspect this document in DOM Inspector".

hewitt isn't the owner of DOM Inspector anymore; I'd be willing to write a patch
for this bug if you really want it.

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

No, this belongs in the context menu/file menu.  (See CTRL+E and File>Edit this
Page)  It used to be in the context menu but it hurt page load or something.

Comment 5

[Alex Vincent [:WeirdAl]]

per e-mail with caillon, I am accepting this bug.

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

The Ctrl+Shift+I binding needs to be removed (or possibly changed).  Netscape IM
uses the binding for sending an instant message.  Alex, can you get to this
soon?  If not send it to me.

Comment 7

[Alex Vincent [:WeirdAl]]

After discussion with caillon, resummarizing.  Patch coming up.

Comment 8

[Alex Vincent [:WeirdAl]]

Attachment: Patch to remove key binding (1.4 branch only)

Comment 9

[Alex Vincent [:WeirdAl]]

Comment on attachment 125111 [details] [diff] [review]
Patch to remove key binding (1.4 branch only)

Patch as requested by Chris.  This has been requested for the Netscape team.

caillon has given r= via IRC.

Personally, I recommend the Netscape team apply this patch for their commercial
build only; I think this is the wrong thing to do for Mozilla.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 125111 [details] [diff] [review]
Patch to remove key binding (1.4 branch only)

unsetting approval request since this doesn't have reviews yet.

Comment 11

[Brian Ryner (not reading)]

Comment on attachment 125111 [details] [diff] [review]
Patch to remove key binding (1.4 branch only)

caillon, what do you want to do with this now?	I don't think the Netscape
release is a concern.

Comment 12

[Brian Ryner (not reading)]

Comment on attachment 125111 [details] [diff] [review]
Patch to remove key binding (1.4 branch only)

I'm going to ask caillon to re-review given the lack of future Netscape
releases.  Let's evaluate this on whether this binding itself is useful.

Comment 13

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 125111 [details] [diff] [review]
Patch to remove key binding (1.4 branch only)

Agreed.  This was always intended for the 1.4 release only, and that's gone.

Comment 14

[Alex Vincent [:WeirdAl]]

No traction, and no reason to keep this bug open.  If someone wants a bug on 
file for its original purpose (Add "Inspect this document in DOM Inspector" 
option to File menu for Navigator), please file a new bug. 

Comment 15

[Jesse Ruderman]

See also bug 251767 for Firefox, "Ctrl+Shift+I shortcut for DOM Inspector not
shown in menu".