152289 - new Filepicker filters for Nvu

Status: NEW

(Firefox :: File Handling, enhancement)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

It is impossible in the client to choose Open File and filter audio files in the
filepicker... We should have a new file picker filter called "Audio Files"
filtering *.au *.wav *.aiff *.mp3 ...
Useful for picking a sound in prefs, opening a music in a plug-in, and so on.

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: patch v1.0

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 87924 [details] [diff] [review]
patch v1.0

r=bryner

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 87924 [details] [diff] [review]
patch v1.0

sr=jst

Comment 4

[Stephen Walker]

glazou?

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

yes, sorry, that r/sr was in the middle on my layoff process at Netscape and
I missed it. I'm going to revive this asap. Thanks for the wake-up call.

Comment 6

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

I am keeping this bug in my fridge a few days since I need another filter
extension for Nvu html templates.

Comment 7

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Updating summary

Comment 8

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 87924 [details] [diff] [review]
patch v1.0

patch is obsolete

Comment 9

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: fix #1

Implements nsIFilePicker.filterSounds and nsIFilePicker.nsIFilePicker for Nvu.
The latter can be ifdef'd on MOZ_STANDALONE_COMPOSER if needed.

Comment 10

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

s/nsIFilePicker.nsIFilePicker/nsIFilePicker.filterHTMLTemplates
sorry for spam...

Comment 11

[timeless]

Comment on attachment 155680 [details] [diff] [review]
fix #1

the my documents change feels out of place. i think i'd rather see that near a
directory service provider. and the order of sound file types is a bit odd.
could you favor the ones likelt to be encountered/used?

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

+  const long filterHTMLTemplates = 0x80;           // HTML templates

hrm... why not use appendFilter in the caller? I'm not sure the filepicker
should know about html templates.

Comment 13

[[e-mail]]

Comment on attachment 155680 [details] [diff] [review]
fix #1

>+#ifdef LINSPIRE
>+    sfile.initWithPath(homeDir.path + "/My Documents");
>+#else
>     sfile.initWithPath(homeDir.path);
>+#endif
What the??? And in xpfe, too!

Comment 14

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Neil: oops, forgot to remove that
Christian: because HTML template don't use the *.html extension but *.mzt ?

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #14)
> Christian: because HTML template don't use the *.html extension but *.mzt ?

appendFilter("HTML Template", "*.mzt"); ?

Comment 16

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5040

Comment 17

[Ed Lee :Mardak]

Wrong bug number in PR. Should have been 1552289.

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.