Closed Bug 155343 Opened 22 years ago Closed 22 years ago

header.html.tmpl has an unused "extra" parameter

Categories

(Bugzilla :: Bugzilla-General, defect)

2.16
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.16

People

(Reporter: toms.baugis, Assigned: jouni)

Details

Attachments

(1 file, 1 obsolete file)

Was trying to enable site navigation bar and found following errors in
header.html.tmpl - in interface there are described wrong names:

  # extra: string. Any other HTML to go inside the <head> tags.
this is not used at all in header template, also - edit.html.tmpl calls out
header with parameter "header_html"


  # jscript: string. Javascript to go in the header.
in body is used parameter "javascript"


  # style_urls: list. List of URLs to CSS style sheets.
this one is very funny - [% IF style_urls %] statement correct (in plural), but
link is set in singular ;)
fragment from code:
==============
    [% IF style_urls %]
      [% FOREACH style_url = style_urls %]
        <link href="[% style_url %]" rel="stylesheet" type="text/css">
      [% END %]
    [% END %]
==============
just found bug 149347

i think, this one is bigger the the other one, so - please, dupe it ;)
sorry about style_urls - i didn't read whole code :/
149347 has a patch so I won't dupe it. Let's reduce this to handle the unused
"extra" parameter since all the other issues are either invalid (style_urls) or
handled elsewhere (jscript). 

Gerv, Myk: do you know something about this? Is there a reason for extra not
being used anymore? A similar discussion was in bug 148179 re body_attributes,
which was removed then.
OS: Windows 2000 → All
Hardware: PC → All
Summary: wrong [% interface %] in header.html.tmpl → header.html.tmpl has an unused "extra" parameter
I don't know why extra isn't used anymore, but I'd guess it's because we
replaced it with more specific parameters.  If it isn't being used anymore we
should just get rid of it.
Attached patch v1 (obsolete) — Splinter Review
Remove the extra parameter from the interface comment
taking, adding keywords, targetting 2.16 (this is a documentation correctness
issue with a zero-risk patch).
Assignee: justdave → jouni
Keywords: patch, review
Target Milestone: --- → Bugzilla 2.16
Attached patch v2: RenameSplinter Review
So we really _do_ have that interface param, it's just not called "extra" but
header_html. This patch just renames the param in the interface comment.
Attachment #90057 - Attachment is obsolete: true
Attachment #90069 - Attachment is patch: true
Attachment #90069 - Attachment mime type: text/html → text/plain
Comment on attachment 90069 [details] [diff] [review]
v2: Rename

r=bbaetz x2
Attachment #90069 - Flags: review+
Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v
 <--  header.html.tmpl
new revision: 1.13; previous revision: 1.12
done

Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v
 <--  header.html.tmpl
new revision: 1.5.2.7; previous revision: 1.5.2.6
done
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: