Closed Bug 155957 Opened 22 years ago Closed 21 years ago

[FIXr]input:before { content: ...; } causes caret placement problems for text inputs

Categories

(Core :: CSS Parsing and Computation, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.6final

People

(Reporter: david_emmerson, Assigned: bzbarsky)

References

()

Details

Attachments

(1 file)

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.1a+) Gecko/20020627
BuildID:    2002062713

Adding a style such as input:before { content: "* "; } causes the text inputs to
break. On focusing one, the caret appears well before the input box itself.

Reproducible: Always
Steps to Reproduce:
1. Go to test url
2. Focus the text field

Actual Results:  Caret appears before the box.

Expected Results:  Caret should appear in the box.
If so, this is a regression; it works in NS 6.2.3. cc'ing jkeiser.
Confirming this bug using trunk build 2002070504 - WinXP
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: input:before { content: ...; } causes focus problems for text inputs → input:before { content: ...; } causes caret placement problems for text inputs
This is happening because the primary frame for the <input> is the wrapper frame
(so yes, a regression from bug 141055).
er, bug 141054.  Easy typo to make, apparently.  ;)
Blocks: 228020
Comment on attachment 137174 [details] [diff] [review]
This fixes this bug (well, if I could reprocuce it it should ;)) and the dependency...

david, would you review?
Attachment #137174 - Flags: superreview?(dbaron)
Attachment #137174 - Flags: review?(dbaron)
Taking.
Assignee: dbaron → bz-vacation
OS: Windows 98 → All
Priority: -- → P1
Hardware: PC → All
Summary: input:before { content: ...; } causes caret placement problems for text inputs → [FIX]input:before { content: ...; } causes caret placement problems for text inputs
Target Milestone: --- → mozilla1.6final
Comment on attachment 137174 [details] [diff] [review]
This fixes this bug (well, if I could reprocuce it it should ;)) and the dependency...

r+sr=dbaron, although this function should really return
already_AddRefed<nsIFormControlFrame>*
Attachment #137174 - Flags: superreview?(dbaron)
Attachment #137174 - Flags: superreview+
Attachment #137174 - Flags: review?(dbaron)
Attachment #137174 - Flags: review+
Comment on attachment 137174 [details] [diff] [review]
This fixes this bug (well, if I could reprocuce it it should ;)) and the dependency...

Could this be approved for 1.6?  Simple fix, very safe, makes form controls
with :before and :after content actually submit...
Attachment #137174 - Flags: approval1.6?
Summary: [FIX]input:before { content: ...; } causes caret placement problems for text inputs → [FIXr]input:before { content: ...; } causes caret placement problems for text inputs
Comment on attachment 137174 [details] [diff] [review]
This fixes this bug (well, if I could reprocuce it it should ;)) and the dependency...

a=chofmann for 1.6.  this need to go on the branch at this point.
Attachment #137174 - Flags: approval1.6? → approval1.6+
Someone needs to check this in.  I won't have a tree till January.
fix checked in to trunk and branch
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
*** Bug 229018 has been marked as a duplicate of this bug. ***
*** Bug 152090 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: