Closed Bug 156695 Opened 22 years ago Closed 22 years ago

MailNews support for Windows XP SP1

Categories

(SeaMonkey :: MailNews: Message Display, defect, P1)

x86
Windows XP

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.0.1

People

(Reporter: jaimejr, Assigned: ssu0262)

References

Details

(Whiteboard: [adt1 RTM] [ETA 07/17] [needs QA verification])

Attachments

(1 file, 2 obsolete files)

This is track the MailNews work needed to support Windows XP SP1.

Pls supply the following:
1. An estimate of engineering and QA person days required to implement this
request in the Status Whiteboard
2. Minimum Design Specificaiton (as an attachement)
3. Test Case (as an attachement)
Blocks: 156694
Severity: normal → major
Priority: -- → P1
Whiteboard: [adt1 RTM] [ETA 07/12]
Target Milestone: --- → mozilla1.0.1
reassigning to ssu.
Assignee: putterman → ssu
Blocks: 156698
No longer blocks: 156694
No longer blocks: 156698
Blocks: 156698
Attached patch patch v1.0 (obsolete) — Splinter Review
this patch will add new cmdline option to mozilla.exe:
 -setDefaultMail
 -unsetDefaultMail

it will preserve the previous state that mozilla.exe was in, either leave it
running if it was running, or quit if it was not running.

It works with turbo feature too.  If it was in turbo mode without any windows
open, it will leave it in that state when it's done.

testing scenarios for browser not running, running in non-turbo mode, and
running in turbo mode:
  mozilla.exe -setDefaultMail
  mozilla.exe -unsetDefaultMail

you can check the prefs after it's run to see if it worked.

I'm still testing the patch to see where I need to also update in packages-win,
but wanted to put this patch out for now.
Attached patch patch v1.1 (obsolete) — Splinter Review
this is a better patch.  this patch is dependent on Bill Law's patch in bug
156698.
Attachment #90847 - Attachment is obsolete: true
No longer blocks: 156698
Status: NEW → ASSIGNED
Depends on: 156698
Blocks: 156698
No longer depends on: 156698
Comment on attachment 91084 [details] [diff] [review]
patch v1.1

r=law
Attachment #91084 - Flags: review+
Comment on attachment 91084 [details] [diff] [review]
patch v1.1

I noticed this code is in xpfe/components/winhooks.

What happens if mail isn't installed? Does this code get executed?

Should this code be moved to the mailnews module or does it have to in
winhooks?
Per Rajiv, if mail is not installed, the code (in nsSetDefaultMail.js and
nsUnsetDeaultMail.jst) is harmless.

also forgot to attach the patch to packages-win so that it'll get packaged up
with the browser.xpi file:

Index: packages-win
===================================================================
RCS file: /cvsroot/mozilla/xpinstall/packager/packages-win,v
retrieving revision 1.207.2.9
diff -u -r1.207.2.9 packages-win
--- packages-win        28 Jun 2002 00:22:12 -0000      1.207.2.9
+++ packages-win        13 Jul 2002 04:26:32 -0000
@@ -264,6 +264,8 @@
 bin\components\transformiix.dll
 bin\ISimpleDOMNodeMarshal.dll
 bin\ISimpleDOMDocumentMarshal.dll
+bin\components\nsSetDefaultMail.js
+bin\components\nsUnsetDefaultMail.js
It may be harmless, I'm just asking if we think it belongs there or if it
belongs in a mailnews module? This is a new file we are adding right? 
gotcha.  I just moved it to the mail section in packages-win.  it'll get
installed with mail.xpi now.  so if the .js files are not there and we try the
command line -setDefaultMail/-unsetDefaultMail, nothing should happen.

Diff for packages-win now looks like (sorry I can't attach a clean patch.  got
too much stuff in my tree right now):
Index: packages-win
===================================================================
RCS file: /cvsroot/mozilla/xpinstall/packager/packages-win,v
retrieving revision 1.207.2.9
diff -u -r1.207.2.9 packages-win
--- packages-win  28 Jun 2002 00:22:12 -0000  1.207.2.9
+++ packages-win  16 Jul 2002 01:37:51 -0000
@@ -385,6 +385,8 @@
 bin\components\msgmdn.dll
 bin\components\msgmdn.xpt
 bin\components\mdn-service.js
+bin\components\nsSetDefaultMail.js
+bin\components\nsUnsetDefaultMail.js

 [chatzilla]
 bin\components\chatzilla-service.js
Comment on attachment 91084 [details] [diff] [review]
patch v1.1

thanks sean!

sr=mscott
Attachment #91084 - Flags: superreview+
Comment on attachment 91084 [details] [diff] [review]
patch v1.1

You might want to correct some comments e.g. "The Original Code is Mozilla Kill
All."
Attached patch patch v1.1.1Splinter Review
minor update (comments cleanup as suggested by neil)
Attachment #91084 - Attachment is obsolete: true
Comment on attachment 91659 [details] [diff] [review]
patch v1.1.1

moving r=, sr= to here since it's only a comment change.

I've also included the packages-win diff in the latest patch.
Attachment #91659 - Flags: superreview+
Attachment #91659 - Flags: review+
Whiteboard: [adt1 RTM] [ETA 07/12] → [adt1 RTM] [ETA 07/17] [needs QA verification]
adding adt1.0.1+.  Please get drivers approval before checking in.
Keywords: adt1.0.1+
patches checked in to the BRANCH only.  I'm closing this bug because it was only
referring to the branch.  I'll open a new bug to have these patches checked into
the TRUNK.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Keywords: fixed1.0.1
Resolution: --- → FIXED
QA Contact: olgam → sheelar
QA Contact: sheelar → trix
build: 20020722 branch
OS: Microsoft XP Professional Build 2600.xpsp1.020529-1810 (Service Pack 1, v.1050)

verification of mail client has been complete with resulted posted on testcases
linked below.  changing keyword to verified1.0.1

testcases can be found at:

http://mrbolo.mcom.com/xpsp1/xpsp1.html

Status: RESOLVED → VERIFIED
testcases have now been postedon slip:

http://slip.mcom.com/client/mailnews/MachV/bug156695.html
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: