157085 - process_bug midair check happens too late

Status: RESOLVED DUPLICATE of bug 97963

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Bradley Baetz (:bbaetz)]

Matti reported this, and its a wierd one.

1. Have a bug open in two browser windows
2. In one window, change the product
3. Select the approciate compoent/version
4. Change the product in the second window to the same product as in (2).

Expected:

- midair collision warning.

Actual:

- get the 'A legal Component was not set.' error (what happened to the
browserbug text, btw?)

What happens here is that the code sees the that product you set is the same as
is in the db, so we skip the verify-new-product stuff. Then we see that
$::FORM{'component'} isn't in $::FORM{'product'}'s components, and barf.

Note that this is not a regression; 2.14 gives the same error if
strictvaluechecks are turned on. If they are off (which is the default), then
the change gets the midair, but if you force it to continue anyway, you don't
get the product change page, so you keep the old component on the new product. Oops.

A solution to this needs to stop that from happening, too, and thats more
complicated than just moving the midair check. Putting the old product in a
hidden form element wouldn't stop people from editing it manually. Maybe we
shouldn't allow forcing a midair if theres a product change? That feels hacky to
me. If we add a hidden form element to the midair page, then mayw ewe could do
something based on that...

Ideas?

Comment 1

[Jouni Heikniemi]

We talked about this on IRC, and agreed something like that we're going to add
that hidden field into 2.16 and rewrite process_bug soon. :-) Bbaetz, do I
remember correctly? If so, we might want to target this at 2.16 now...

Comment 2

[Bradley Baetz (:bbaetz)]

No, this isn't a regression, and so should not be targetted at 2.16.

I had a better soln, but I can't quite remember it ATM....

Comment 3

[Bradley Baetz (:bbaetz)]

Dupe of bug 97963

*** This bug has been marked as a duplicate of 97963 ***

Comment 4

[Dave Miller [:justdave]]

clearing target in DUPLICATE/WORKSFORME/INVALID/WONTFIX bugs so they'll show up
as untriaged if they get reopened.