157474 - Error.stack no longer quotes string arguments to functions

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Phil Schwartau]

Testcase js1_5/Exceptions/errstack-001.js is failing as follows:

------------------------------------------------------------
js1_5/Exceptions/errstack-001.js failed Bug Number (none)
STATUS: Testing Error.stack
Failure messages were:

FAILED!: Section 7 of test -
FAILED!: Expected value 'A("44:foo","13:bar")@'
         Actual value   'A(44:foo,13:bar)@./js'
------------------------------------------------------------


In Error.stack, it used to be that string arguments to functions
were presented with double-quotes, and this test used to pass.
But now, string arguments are no longer being presented that way.
Is this by design, or is it a bug?

Note that Error.stack was created in response to bug 123177,
but was modified in response to bug 127136.

I would like to lobby for including the double-quotes again.
My argument: the toSource() method:

             js> var arr = new Array("999", 999)
             js> arr.toString();
             999,999
             js> arr.toSource();
             ["999", 999]


I think the |Error.stack| is analogous to the toSource() feature in
some sense, and should include double-quotes. It gives useful info -

Comment 1

[Brendan Eich [:brendan]]

I snuck the fix for this in with the fix for bug 166743.

/be

Comment 2

[Phil Schwartau]

Marking Verified Fixed.

The above testcase now passes in the debug/optimized JS shell -