157638 - Land VENKMAN_FLOATS_MY_BOAT branch

Status: VERIFIED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Robert Ginda]

Comment 1

[Robert Ginda]

The floating window branch has lived long enough, it's about time to land it on
the trunk.  Getting it into 1.1b would be a Good Thing.

Comment 2

[Scott Collins]

It's pretty late for 1.1b, but since I've spoken to you personally about this
landing, you've done your homework by merging and testing already, and because
you have a good reason to get it into 1.1b (extra eyeballs), I'm approving this.
 As per our discussion, you need to pay close attention and be ready to
pre-emptively solve any problems for this landing.

a=scc for checkin to the mozilla trunk

Comment 3

[Robert Ginda]

This check-in made the tinderbox numbers go up.  Sorry, I should have disclaimed
this before I checked in.  The numbers go up *only* when the debugger UI is
installed.  The extra time is spent instrumenting JSScript*s as they are
created, something we *have* to do if we want to be able to debug scripts that
were loaded before the debugger UI is started.  Based on feedback from previous
Venkman releases, most users expect that to Just Work, and so the "init at
startup" option was enabled by default.

Users who want the debugger installed, but are willing to trade init-at-startup
for speed can type "startup-init off" in the Venkman "Interactive Session" view.

Comment 4

[Scott Collins]

I understand the numbers and the trade-off.  I remain in favor as this doesn't
affect typical users, and is as controllable as reasonble by debugger-saavy users.

Comment 5

[Robert Ginda]

marking fixed.

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

The branch has landed.  Verified.