159627 - quips should be editable and deleteable using the web interface

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect, P4)

Description

[Tobias Burnus]

Until recently the quips had been stored in data/comments. Now they have been
moved into the database it had become much more difficult to delete (or change)
quips. The problem is that quips can be added by anyone (needn't to be logged
in/anonymous) which potentially increases the number of obscene or offensive quips .

Don't know who should be able to edit/delete them. At least the admin should to
so for sure.

Comment 1

[Gervase Markham [:gerv]]

This is a fair point - although the userid of the person who contributes the
quip is now logged.

I think disabling anonymous quip contribution (without any sort of pref) is
perfectly reasonable. quips should be by regular users for regular users. If you
want to add a quip, get an account.

Gerv

Comment 2

[Bradley Baetz (:bbaetz)]

Didn't someone disable anonymous quip submission last week? I thought I saw that
bug go by somewhere.

Comment 3

[Gervase Markham [:gerv]]

Yep, we did that. But this bug is still valid.

Gerv

Comment 4

[Tobias Burnus]

Make sure that this doesn't get lost (bug 67950 comment 27):
> Once the groups system gets rewritten we should add 'addquips' and
> 'removequips' groups.
(this makes of cause only sense if bug 157756 gets checked in first, but maybe
instead of 'removequips' it should be 'editquips')

Comment 5

[Gervase Markham [:gerv]]

I disagree that these two things require groups. Quips are not important enough
for it to be worth the added complexity. addquips should be equivalent to
editbugs, and editquips should be equivalent to some admin-level group.

Gerv

Comment 6

[Tobias Burnus]

> addquips should be equivalent to editbugs, and editquips should be equivalent to 
> some admin-level group.
For our use it would be also ok if anyone who has logged in an add quips.

Comment 7

[Matthew Tuck [:CodeMachine]]

Well given the plan is for editbugs to go away and be replaced with a fine
grained system, it seems kind of silly to say editbugs is enough.

And the chance of multiple installations not wanting to set up a different add
quips group is almost nil.

Comment 8

[Gervase Markham [:gerv]]

What I said was a shorthand for the following:

Quips are a trivial and fun part of Bugzilla; as far as possible, they should
fit in with what's going on without requiring special consideration. It
therefore seems sane to make "addquips" equivalent to some sort of semi-trusted
role like editbugs, and "editquips" equivalent to some sort of
semi-administrator role. Whichever roles are appropriate in the new scheme could
be used. 

I doubt very much that any admin cares about quips enough to want to set up a
special group of people who are permitted to add them or edit them. We just want
a sensible scheme which means random people can't insert rude/offensive quips.

Gerv

Comment 9

[Dave Miller [:justdave]]

*** Bug 163769 has been marked as a duplicate of this bug. ***

Comment 10

[Gervase Markham [:gerv]]

I am assigning all the bugs I am not working on in the immediate future to
[e-mail]. This means:

- I will be able to search for bugs assigned to me as a list of bugs I'm going
to fix (which is as it should be), and
- people won't falsely assume I might be about to fix a bug when I'm not.

Gerv

Comment 11

[Tobias Burnus]

-> Me

Comment 12

[Tobias Burnus]

Attachment: v1: Add ability to delete a quip

This adds the ability to delete a quip. Since the deleted quip is shown, one
can edit it by adding the modified quip, which should be sufficient.
I use the group "admin" as group which can delete quips.

Comment 13

[Tobias Burnus]

Attachment: v1.1: Fix tiny nits by timeless

Comment 14

[Tobias Burnus]

Attachment: v1.2: Fix spacing & use "unless" which saves one line & change code-error text (makes timeless happy)

(I really need to learn counting to four/two for indenting.
Btw: Do you know this joke: "There are three types of mathematicians: One part
can count up to three, the others cannot.")

Comment 15

[timeless]

Comment on attachment 108682 [details] [diff] [review]
v1.2: Fix spacing & use "unless" which saves one line & change code-error text (makes timeless happy)

i'm happy, sorry about the extra diffs..

Comment 16

[Joel Peshkin]

Checked in for Burnus

Checking in quips.cgi;
/cvsroot/mozilla/webtools/bugzilla/quips.cgi,v  <--  quips.cgi
new revision: 1.16; previous revision: 1.15
done
Checking in template/en/default/global/code-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-error.html.tm
pl,v  <--  code-error.html.tmpl
new revision: 1.24; previous revision: 1.23
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tm
pl,v  <--  user-error.html.tmpl
new revision: 1.25; previous revision: 1.24
done
Checking in template/en/default/list/quips.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/quips.html.tmpl,v  <
--  quips.html.tmpl
new revision: 1.7; previous revision: 1.6
done                                        

Comment 17

[Gervase Markham [:gerv]]

Er... did no-one think of suggesting that we use the current big quip list and
add a "delete" link for each if the user is an admin, rather than duplicating
the code which reads all the quips in from the database?

Gerv

Comment 18

[Gervase Markham [:gerv]]

burnus, justdave: ping?

Gerv

Comment 19

[Dave Miller [:justdave]]

nope, apparently nobody thought of that.

Comment 20

[Gervase Markham [:gerv]]

Right. So, shall we do that, then? :-)

Gerv