1602033 - Firefox no longer plays sound if find bar does not find search term

Status: VERIFIED FIXED

(Core :: Find Backend, defect, P1)

Comment 1

[Sören Hentzschel]

Bugzilla lost my description. :-/

STR:

• Open the find bar
• enter a search term which is not on the website

Expected:

Firefox plays a sound.

Actual:

No sound.

13:17.85 INFO: No more inbound revisions, bisection finished.
13:17.85 INFO: Last good revision: 5b303cb0a0a39e2bd4a6fea53535fe8e1d829b97
13:17.85 INFO: First bad revision: e33c3e14ee40f88d1775952e309dc2a617eb97f7
13:17.85 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5b303cb0a0a39e2bd4a6fea53535fe8e1d829b97&tochange=e33c3e14ee40f88d1775952e309dc2a617eb97f7

Comment 3

[Mike de Boer [:mikedeboer]]

Neil, this is a regression from bug 1553384, can you please take a look?

Comment 4

[Chris Peterson [:cpeterson]]

Tentatively assigning to Neil because he said planned to investigate these findbar regressions next week.

Tracking for Fission dogfooding (M5)

Comment 5

[Neil Deakin]

Attachment: Bug 1602033, typeaheadfind component plays the search term not found sound effect, but only when searching subframes, instead play the sound in FinderParent module if search text does not exist, r=mikedeboer

Comment 6

[Mike de Boer [:mikedeboer]]

Sören, to be sure: is this only happening for you with Fission enabled? Or also with no special preferences changed?

Comment 7

[Sören Hentzschel]

If Fission is not enabled in the stable release of Firefox 71 (and I am almost sure it's not enabled) then it also affects Firefox with Fission disabled because this regression was reported by multiple users in a Firefox support forum after the release of Firefox 71.

I used mozregression to find the cause of the regression so I think no special preferences should be changed.

Comment 8

[Zitronella]

I use Firefox 71 64bit under Win10 1903 (18362.535) and can confirm the problem with fresh Firefox profile since Version 71 (release)
All entries with word "fission" under about:config are false (default)

Comment 9

[Chris Peterson [:cpeterson]]

We don't need to track this bug for Fission if the Findbar sound is also broken in non-Fission mode.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf0698d83783
typeaheadfind component plays the search term not found sound effect, but only when searching subframes, instead play the sound in FinderParent module if search text does not exist, r=mikedeboer

Comment 11

[Andreea Pavel [:apavel]]

Backed out for causing bug 1607230

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=cf0698d83783455a52c99586d74b3d99576fe1a7&selectedJob=283625985

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283625985&repo=autoland&lineNumber=2692

Backout: https://hg.mozilla.org/integration/autoland/rev/a0d7029014d0516f43a780bbfa1b661746476d90

Comment 12

[Neil Deakin]

The updated version just adds a try/catch around the sound initialization as Android doesn't have a sound component.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fa486702a3d
typeaheadfind component plays the search term not found sound effect, but only when searching subframes, instead play the sound in FinderParent module if search text does not exist, r=mikedeboer

Comment 14

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3fa486702a3d

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval assuming you feel this is something we could safely uplift. We probably want QA to verify this fix too.

Comment 16

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Hi,
I just checked the last nightly build and I was able to verify the fix, now when searching a term that is not present in the page using the find bar , the sound will be triggered.
Thanks, I've updated the flags for 74.0a1 (2020-01-08) (64-bit) version.
Best,
Clara.

Comment 17

[Neil Deakin]

Comment on attachment 9118055 [details]
Bug 1602033, typeaheadfind component plays the search term not found sound effect, but only when searching subframes, instead play the sound in FinderParent module if search text does not exist, r=mikedeboer

Beta/Release Uplift Approval Request

• User impact if declined: Sound/beep when text from a 'find in page' is not found does not play. Users may rely on this sound to know if a term was not found.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed: None

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9118055 [details]
Bug 1602033, typeaheadfind component plays the search term not found sound effect, but only when searching subframes, instead play the sound in FinderParent module if search text does not exist, r=mikedeboer

Fixes a regression causing sound to not play when the find bar doesn't find anything. Approved for 73.0b4.

Comment 19

[Dorel Luca [:dluca]]

https://hg.mozilla.org/releases/mozilla-beta/rev/019649d9c437

Comment 20

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Hi,
I just checked FF Beta v73.0b5 (64-bit) Build ID 20200115020958 and I was able to verify the fix, now when searching a term that is not present in the page using the find bar , the sound will be triggered.
I checked on MacOS 10.14.5, Ubuntu 18.04.2 LTS, and Windows 8.1, 64-bit
Thanks, I've updated the flags to verified.
Best,
Clara.