160210 - Add MacOSX 10.1 and 10.2 to the os list

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement, P2)

Description

[timeless]

MacOSX 10.1 exists and is significantly different from 10.0.4 (iirc MS requires
10.1).  MacOSX 10.2 will be a significantly changed creature and was requested
in bug 160146 comment 6

Comment 1

[Bradley Baetz (:bbaetz)]

Do you have useragent strings for these?

Comment 2

[timeless]

Please add it.

Please don't wait for me to figure out a useragent mask for them.
If/when I find useragent masks for it, i'll file my own bugs for that, as i own
that code and it does not relate to the need for the os.

Note that I'll have to try to get masks for mozilla, chimera, ie5, omniweb, iCab
and opera.  But such collection is really well beyond the scope of this bug and
will take time and resources, whereas this does not.

Comment 3

[Bill McGonigle (not currently reading bugmail; please contact directly)]

Ditto.  

We're starting to see bugs that only apply to 10.2, since it's so different in
lots of ways.  Need to be able to query against it properly.

Comment 4

[Bill McGonigle (not currently reading bugmail; please contact directly)]

Forgive my ignorance, but is this all we need?

*** bugzilla-2.16/checksetup.pl Thu Sep  5 18:06:08 2002
--- bugzilla-2.16-osx/checksetup.pl     Thu Sep  5 18:22:25 2002
***************
*** 513,518 ****
--- 513,520 ----
          "Mac System 8.6",
          "Mac System 9.x",
          "MacOS X",
+         "MacOS X 10.1",
+         "MaxOS X 10.2",
          "Linux",
          "BSDI",
          "FreeBSD",



There aren't any new user agent strings, as far as I can tell.  All my browsers
on 10.2 are still sending Mac OS X, e.g.

"Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20020904"

Comment 5

[timeless]

yep, that's all it takes. see bug 52577 which added MacOS X.

Comment 6

[Dave Miller [:justdave]]

Since this bug is filed in the Bugzilla product, that implies we want code
changes in the distributed Bugzilla and not to a specific installation.  In that
case, the above quoted patch is all we need.

HOWEVER, that only changes new installations.

On an existing installation you need to modify localconfig.  (The lines being
changed should look identical - the code you're quoting in checksetup.pl is the
default that's written to localconfig if that variable isn't present there yet.)

nit pick mode on:  note that it's Mac OS X and not MaxOS :) (note the small "x" :)

Comment 7

[Dave Miller [:justdave]]

Attachment: Patch

patch changes MacOS X to Mac OS X (per Apple's encouraged usage) and adds 10.1
and 10.2

Comment 8

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 98074 [details] [diff] [review]
Patch

r=caillon

Comment 9

[J. Paul Reed [:preed]]

Comment on attachment 98074 [details] [diff] [review]
Patch

r2=, if you needed it.

Comment 10

[Dave Miller [:justdave]]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.186; previous revision: 1.185
done

Bug 167002 filed again mozilla.org to add this to the live Bugzilla installation.

Comment 11

[Bill McGonigle (not currently reading bugmail; please contact directly)]

Do we need some code to change existing databases' 'MacOS X' to 'Mac OS X 10.0'
when upgrading?

That was my rational in leaving 'MacOS X' in comment #4, anyhow.

Comment 12

[timeless]

vrfy fixed

Comment 13

[Dave Miller [:justdave]]

If you want to change it, you can do so yourself.  The code that was checked
into checksetup.pl only affects NEW installations.  If you already have an
@opsys list defined in your localconfig file, checksetup.pl won't touch it.

If you want to change it on your existing installation, you'd need to do the
following:

1) Edit localconfig, and add "Mac OS X 10.0" to your OS list.  DO NOT remove
"MacOS X" yet.
2) Run checksetup.pl.  This will pick up what you have in localconfig and change
the scheme for the OS column to match what's in localconfig.  This will not
alter any existing bugs.
3) Log into the MySQL client, then run the following SQL:
UPDATE bugs SET op_sys = 'Mac OS X 10.0' WHERE op_sys = 'MacOS X';
4) Edit localconfig again, and NOW you can remove the entry for "MacOS X".
5) Run checksetup.pl to pick up the changes and alter the schema to remove the
"MacOS X" choice.

Comment 14

[Dave Miller [:justdave]]

I forgot to mention, the reason that you add it first, then use SQL to change
them all to the other one, then remove the old one, rather than just changing it
in place, is that MySQL isn't going to know that you're changing it.  It's going
to think you're adding one and removing another at the same time.  If you do
this (change it in place, instead of adding first then removing), all of your
existing bugs that have "MacOS X" as the opsys will wind up getting a NULL opsys
because MySQL won't know what to change it to.

Enums suck, and they're going away one of these days, but that's another bug. :)

Comment 15

[timeless]

Someone forgot to update checksetup. This is broken.

Comment 16

[timeless]

Attachment: repair damage

comment 5 was not a blank check to people to randomly change lines of code near
there. it was for a very specific change. (and yes i sleepily verified the
bug.)

Comment 17

[timeless]

mozilla/webtools/bugzilla/enter_bug.cgi 	1.92