160279 - checksetup.pl doesn't check permission on data/comments

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Timothee Besset]

After installing bugzilla-2.16, quips were not working. cgi says 'ok your quip
is in', but it never actually got in. turns out this is a permission problem in
data/:

total 32
-rw-r--r--    1 root     www-data        0 Jul 30 04:56 comments
drwxr-x---    2 root     www-data     4096 Jul 30 04:56 duplicates
-rw-r--r--    1 root     www-data        0 Jul 30 04:56 mail
drwxr-sr-t    2 root     www-data     4096 Jul 30 04:56 mimedump-tmp
drwxr-x---    2 root     www-data     4096 Jul 30 04:56 mining
-rw-r--r--    1 root     www-data        0 Jul 30 04:56 nomail
-rw-rw----    1 www-data www-data     4808 Jul 30 06:07 params
drwxrwx---    3 root     www-data     4096 Jul 30 04:56 template
-rw-rw----    1 www-data www-data     1731 Jul 31 04:26 versioncache
drwxrwx---    2 root     www-data     4096 Jul 30 04:56 webdot

www-data needs to have write permissions. this should be dealt with by checksetup.pl

Comment 1

[Bradley Baetz (:bbaetz)]

True.

On the trunk, quips are in the database, so data/comments is irrelevent.

Do we want to fix this for 2.16.1 (assuming we have one)?

Comment 2

[Matthew Tuck [:CodeMachine]]

Did this happen due to something checksetup did wrong?  If not, I don't think
it's important enough to fix.

Comment 3

[Timothee Besset]

it makes quip non functional
not that quips are an essential feature, but they won't work without proper
permissions

Comment 4

[Steve Wadsworth]

Attachment: proposed patch for checksetup.pl

I ran across this some time ago, and again recently on a new installation. 
After fixing the problem locally, I thought I'd "do the right thing" and pass
along the patch.  Since checksetup.pl creates the file, it should set its
permissions properly as well.

Comment 5

[Dave Miller [:justdave]]

dangit, where did this get lost at.

Comment 6

[Dave Miller [:justdave]]

Comment on attachment 121368 [details] [diff] [review]
proposed patch for checksetup.pl

err....   we're missing a quote here, that won't work.

Comment 7

[Steve Wadsworth]

Oops.  The quote was there before (in my working version), but I must have made
a typo when I pulled from CVS and edited (so the patch file format would be
right).  Wouldn't you know it:  first time I submit a patch and I bungle it ...

Comment 8

[Zach Lipton [:zach]]

Attachment: v2, add missing quote

Comment 9

[Dave Miller [:justdave]]

zach: please also add this to the 2.16.3 release notes in the "other bugs"
section.  (and can you also check this in on the 2.16 branch only?)  thanks

Comment 10

[Zach Lipton [:zach]]

Fix checked in and entry added to draft relnotes (bug 202738). Thanks Steve for
fixing this.